GNOME Bugzilla – Bug 711693
rtpsession: Implement various session statistics
Last modified: 2013-11-15 14:22:52 UTC
This patch implements a number of statistics about feedback packets in rtpsession: ◦ Number of retransmission events received ◦ Number of retransmission events dropped because of RTCP bandwidth constraints ◦ Number of FB NACK packets sent ◦ Number of FB NACK received
Created attachment 259282 [details] [review] gstrtpsession: Implement a number of feedback packet statistics
Review of attachment 259282 [details] [review]: ::: gst/rtpmanager/gstrtpsession.c @@ +835,3 @@ + break; + case PROP_RECV_NACK_COUNT: + g_object_set_property (G_OBJECT (priv->session), "nacks-recieved", value); You probably need g_object_get_property in all 3 cases ::: gst/rtpmanager/rtpsession.c @@ +707,3 @@ + break; + case PROP_NACKS_SENT: + g_value_set_uint (value, sess->stats.nacks_dropped); s/dropped/sent/ ::: gst/rtpmanager/rtpsession.h @@ +284,3 @@ guint sender_ssrc, guint media_ssrc, GstBuffer *fci); void (*send_rtcp) (RTPSession *sess, GstClockTime max_delay); + void (*on_nack_dropped) (RTPSession *sess, guint count); Where is that being used?
Created attachment 259577 [details] [review] gstrtpsession: Implement a number of feedback packet statistics Huh, odd. Chrome uploaded the older version of the patch. This one I've confirmed is correct.
Comment on attachment 259577 [details] [review] gstrtpsession: Implement a number of feedback packet statistics Please could you provide the patch in "git format-patch" format? (git format-patch -1)
Created attachment 259581 [details] [review] gstrtpsession: Implement a number of feedback packet statistics reformatted with git format-patch
like the rtpjitterbuffer, please make a stats property that returns a structure so that we can make the stats an atomic snapshot and so that we can easily add more things to it later.
Created attachment 259876 [details] [review] gstrtpsession: Implement a number of feedback packet statistics
commit acf74435e3a713a7d0fd685abad86e6a61eef51f Author: Torrie Fischer <torrie.fischer@collabora.co.uk> Date: Fri Nov 15 15:20:14 2013 +0100 gstrtpsession: Implement a number of feedback packet statistics Fixes https://bugzilla.gnome.org/show_bug.cgi?id=711693