GNOME Bugzilla – Bug 711680
Should use symbolic icons in UI
Last modified: 2013-11-08 19:30:11 UTC
GNOME 3 applications use symbolic icons, so Cheese should too. https://wiki.gnome.org/Design/Apps/Cheese#Tentative_Design_2
Created attachment 259268 [details] [review] Change stock icons to symbolic icons.
Created attachment 259278 [details] [review] Change stock icons to symbolic icons. Remove the unused icons from git.
Review of attachment 259278 [details] [review]: The changes in the patch are fine, just a couple of issues with indentation. Also, for the first link of the commit message, please remove the full stop (period). ::: Makefile.am @@ -311,3 @@ iconthemedir = $(datadir)/icons/hicolor -appsicon16dir = $(iconthemedir)/16x16/apps I do not think that you meant to remove the 16x16 application icon, as that still exists in git. ::: data/cheese-main-window.ui @@ +46,3 @@ <property name="tooltip_text" translatable="yes">Photo mode</property> + <property name="label" translatable="yes">Photo</property> + </object> The </object> looks like it has been reindented to use tabs instead of spaces. It should have been unchanged.
Created attachment 259289 [details] [review] Change stock icons to symbolic icons Remove the unused icons from git.
Created attachment 259295 [details] [review] Change stock icons to symbolic icons.
Created attachment 259297 [details] [review] Centered the capture icon
Comment on attachment 259295 [details] [review] Change stock icons to symbolic icons. Pushed to master as commit dae849d56d8ecbb7ee11727756e7fc1cc6c2bd3b, thanks!
Comment on attachment 259297 [details] [review] Centered the capture icon Pushed to master as commit 047ee8a9b139025a48a724552c1bcefa1df45c45, thanks.