After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711668 - Port the toolbar to GtkHeaderBar
Port the toolbar to GtkHeaderBar
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Controls
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 707450 (view as bug list)
Depends on: 708994
Blocks:
 
 
Reported: 2013-11-08 12:30 UTC by Yosef Or Boczko
Modified: 2014-01-02 17:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ephy-location-entry: Set default size and allow to reduced the entry (1.83 KB, patch)
2013-11-08 12:44 UTC, Yosef Or Boczko 		rejected Details | Review
ephy-toolbar: Port to GtkHeaderBar (7.84 KB, patch)
2013-11-08 12:47 UTC, Yosef Or Boczko 		none Details | Review
ephy-toolbar: Port to GtkHeaderBar (9.15 KB, patch)
2013-11-21 12:00 UTC, Yosef Or Boczko 		committed Details | Review

Description Yosef Or Boczko 2013-11-08 12:30:06 UTC 
Well, I was wrong.
It possible to use GtkHeaderBar in the tolbar,
and it is works perfect.
Comment 1 Yosef Or Boczko 2013-11-08 12:44:51 UTC 
Created attachment 259252 [details] [review]
ephy-location-entry: Set default size and allow to reduced the entry

This is the patch from bug 708994.
We must this bug before port the
toolbar to GtkHeaderBar, for good
margin.
Comment 2 Yosef Or Boczko 2013-11-08 12:47:50 UTC 
Created attachment 259255 [details] [review]
ephy-toolbar: Port to GtkHeaderBar
Comment 3 Claudio Saavedra 2013-11-08 12:57:58 UTC 
Review of attachment 259252 [details] [review]:

Instead of adding this patch here again, please mark this bug as depending on the other one.
Comment 4 Yosef Or Boczko 2013-11-21 12:00:50 UTC 
Created attachment 260420 [details] [review]
ephy-toolbar: Port to GtkHeaderBar
Comment 5 Claudio Saavedra 2013-11-21 12:21:00 UTC 
Review of attachment 260420 [details] [review]:

Didn't test it but it looks good. Please go ahead.
Comment 6 Yosef Or Boczko 2013-11-21 12:23:57 UTC 
Review of attachment 260420 [details] [review]:

pushed as b0f30bad0c1f6654055cb57cdb47a60902fb505c - ephy-toolbar: Port to GtkHeaderBar
Comment 7 William Jon McCann 2014-01-02 17:15:48 UTC 
*** Bug 707450 has been marked as a duplicate of this bug. ***