After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711661 - Next/Previous not included in CurrentTransportActions
Next/Previous not included in CurrentTransportActions
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: librygel-renderer
git master
Other Linux
: Normal normal
: ---
Assigned To: Jussi Kukkonen
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2013-11-08 10:17 UTC by Jussi Kukkonen
Modified: 2013-11-10 13:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
(This is an unrelated triviality: Noticed it when I accidentally tried to play a m3u (1.03 KB, patch)
2013-11-08 13:45 UTC, Jussi Kukkonen 		committed Details | Review
renderer: Add Next and Previous to CurrentTransportActions (1.51 KB, patch)
2013-11-08 13:45 UTC, Jussi Kukkonen 		committed Details | Review

Description Jussi Kukkonen 2013-11-08 10:17:03 UTC 
It seems Next/Previous are never included in CurrentTransportActions. They should be when (PlayerController.track < PlayerController.n_tracks - 1).

Should not be a tricky fix, will take a look.
Comment 1 Jussi Kukkonen 2013-11-08 13:45:11 UTC 
Created attachment 259272 [details] [review]
(This is an unrelated triviality: Noticed it when I accidentally tried to play a m3u

playlist from rygel server, and saw rygel renderer printing useless warnings)



renderer: Accept missing mime type in AVTransport.is_playlist()

"assertion 'mime != NULL' failed" is not useful here.
Comment 2 Jussi Kukkonen 2013-11-08 13:45:39 UTC 
Created attachment 259273 [details] [review]
renderer: Add Next and Previous to CurrentTransportActions
Comment 3 Jens Georg 2013-11-08 18:35:20 UTC 
Review of attachment 259272 [details] [review]:

ok
Comment 4 Jens Georg 2013-11-08 18:35:49 UTC 
Review of attachment 259273 [details] [review]:

Looks good
Comment 5 Jens Georg 2013-11-10 13:55:51 UTC 
Attachment 259273 [details] pushed as 361ff5e - renderer: Add Next and Previous to CurrentTransportActions