After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711607 - client: make make_path_from_uri a vmethod
client: make make_path_from_uri a vmethod
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
unspecified
Other Linux
: Normal enhancement
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-07 12:48 UTC by Patricia Muscalu
Modified: 2014-02-25 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
client: make make_path_from_uri a vmethod (4.51 KB, patch)
2013-11-07 12:48 UTC, Patricia Muscalu 		needs-work Details | Review
client: make make_path_from_uri a vmethod (4.79 KB, patch)
2013-11-12 08:18 UTC, Patricia Muscalu 		committed Details | Review

Description Patricia Muscalu 2013-11-07 12:48:46 UTC 
Created attachment 259179 [details] [review]
client:  make make_path_from_uri a vmethod

Make it possible to transform an url into a path in a more flexible way, with the possibility to do e.g url mappings (based on the query part of the the url).
Comment 1 Sebastian Dröge (slomo) 2013-11-11 17:49:07 UTC 
Review of attachment 259179 [details] [review]:

Makes sense I guess :)

::: gst/rtsp-server/rtsp-client.c
@@ +155,3 @@
   klass->params_set = default_params_set;
   klass->params_get = default_params_get;
+  klass->make_path_from_uri = make_path_from_uri;

Better call it default_make_path_from_uri

::: gst/rtsp-server/rtsp-client.h
@@ +93,3 @@
   GstRTSPResult   (*params_set) (GstRTSPClient *client, GstRTSPContext *ctx);
   GstRTSPResult   (*params_get) (GstRTSPClient *client, GstRTSPContext *ctx);
+  gchar *         (*make_path_from_uri) (GstRTSPClient *client, GstRTSPUrl *uri);

Can the GstRTSPUrl be const? If so, do that
Comment 2 Patricia Muscalu 2013-11-12 08:18:09 UTC 
Created attachment 259640 [details] [review]
client:  make make_path_from_uri a vmethod
Comment 3 Wim Taymans 2013-11-12 11:09:10 UTC 
commit 8ce453d97d5a986f68cf34a57b0d663539634614
Author: Patricia Muscalu <patricia@axis.com>
Date:   Thu Nov 7 13:22:09 2013 +0100

    client: make make_path_from_uri a vmethod