GNOME Bugzilla – Bug 711604
Add documentation about thumbnailers and thumbnailer files
Last modified: 2013-12-16 08:50:20 UTC
Patch coming which adapts my recent blog entry (http://tecnocode.co.uk/2013/10/21/writing-a-gnome-thumbnailer/) to fit in the libgnome-desktop reference manual so it’s easier to find and use offline.
Created attachment 259175 [details] [review] thumbnailer: Add documentation on thumbnailers and .thumbnailer files
Review of attachment 259175 [details] [review]: There's no mention of the factory doing fallback for image types handled by GdkPixbuf. Rest looks good, very useful! ::: libgnome-desktop/gnome-desktop-thumbnail.c @@ +41,3 @@ + * + * To generate a thumbnail, an appropriate thumbnailer program is selected then + * executed, passing it the path of the file to thumbnail, plus a path to write path or URI? @@ +70,3 @@ + * <replaceable>%u</replaceable> is the URI of the file being thumbnailed; + * <replaceable>%i</replaceable> is its filename; <replaceable>%o</replaceable> + * is the filename of the image file to be written to; Watch out for filename vs. file path. IMO, a filename should only refer to the filename without any path components. @@ +71,3 @@ + * <replaceable>%i</replaceable> is its filename; <replaceable>%o</replaceable> + * is the filename of the image file to be written to; + * <replaceable>%s</replaceable> is the maximum desired size of the thumbnail Explain "size". It's the maximum width and height.
Created attachment 264199 [details] [review] thumbnailer: Add documentation on thumbnailers and .thumbnailer files
Review of attachment 264199 [details] [review]: Looks good, thanks for the patch!
Thanks for the detailed review. :-) Attachment 264199 [details] pushed as f5561d7 - thumbnailer: Add documentation on thumbnailers and .thumbnailer files