GNOME Bugzilla – Bug 711590
Miscellaneous warning fixes
Last modified: 2016-12-05 18:04:21 UTC
Patches coming up with a few small fixes for various warnings and build system problems spotted in the last few hours.
Created attachment 259162 [details] [review] build: Fix a typo in a variable name in configure.ac
Created attachment 259163 [details] [review] charts: Fix error handling if gvRenderData() returns an error If libgvc was not built properly or is running against incorrectly versioned plugins, gvRenderData() can fail and return a null string. Ensure libvaladoc handles this correctly.
Created attachment 259164 [details] [review] build: Include libgvc in driver CFLAGS and LIBADD Otherwise the build process can’t find the cgraph.h header.
(In reply to comment #3) > Created an attachment (id=259164) [details] [review] > build: Include libgvc in driver CFLAGS and LIBADD > > Otherwise the build process can’t find the cgraph.h header. See also https://bugzilla.gnome.org/show_bug.cgi?id=703688
Review of attachment 259162 [details] [review]: Good catch thanks :)
Comment on attachment 259162 [details] [review] build: Fix a typo in a variable name in configure.ac Attachment 259162 [details] pushed as 4309792 - build: Fix a typo in a variable name in configure.ac
Review of attachment 259164 [details] [review]: This was committed recently, haven't noticed this bug, sorry.
…and the other pending patch?
> …and the other pending patch? I'm looking forward to review everything missing in two weeks. I'm sorry for the delay.
This is getting to be a very long two weeks. :-(
Comment on attachment 259163 [details] [review] charts: Fix error handling if gvRenderData() returns an error Seems a rebased version of this was pushed in May 2015 but nobody closed the bug. How odd. 0bc6256c00f81cc13a25245dd95ec7ef8672ab61