After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711490 - no error reporting on extension install failure.
no error reporting on extension install failure.
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
3.10.x
Other Linux
: Normal major
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-11-05 14:33 UTC by Michael Meeks
Modified: 2013-11-12 08:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
replace notify_error by notify_information (1.23 KB, patch)
2013-11-05 14:59 UTC, Alex Muñoz
accepted-commit_now Details | Review

Description Michael Meeks 2013-11-05 14:33:41 UTC
I try to install the attached extension; it fails - but there is no error /  warning on the console I get:

INFO    : Extracted zip to /tmp/tmpEqAKai/workspace-grid@mathematical.coffee.gmail.com, copied to /home/michael/.local/share/gnome-shell/extensions/workspace-grid@mathematical.coffee.gmail.com
Traceback (most recent call last):
  • File "/usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_shell_extensions.py", line 258 in _on_file_set
    self.notify_error(_("Invalid extension"))
AttributeError: '_ShellExtensionInstallerTweak' object has no attribute 'notify_error'

HTH :-)
Comment 1 Alex Muñoz 2013-11-05 14:52:50 UTC
Thanks for taking the time to report this bug.
I'll fix it!
Comment 2 Alex Muñoz 2013-11-05 14:59:08 UTC
Created attachment 259019 [details] [review]
replace notify_error by notify_information
Comment 3 John Stowers 2013-11-06 22:04:03 UTC
Review of attachment 259019 [details] [review]:

OK
Comment 4 John Stowers 2013-11-06 22:04:37 UTC
Alex, can you please commit this to master, and cherry-pick to 3-10 branch?
Comment 5 Michael Meeks 2013-11-07 16:46:26 UTC
Thanks Alex & John !
Comment 6 John Stowers 2013-11-12 08:00:17 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.