GNOME Bugzilla – Bug 711470
Move tests from src/tests to test
Last modified: 2013-11-05 23:12:52 UTC
See the attached patch
Created attachment 258999 [details] [review] Update tar format to tar-ustar "tar-ustar selects the ustar format defined by POSIX 1003.1-1988. This format is believed to be old enough to be portable. It fully supports empty directories. It can store file names with up to 256 characters, provided that the file name can be split at directory separator in two parts, first of them being at most 155 bytes long. So, in most cases the maximum file name length will be shorter than 256 characters. However you may run against broken tar implementations that incorrectly handle file names longer than 99 characters (please report them to bug-automake@gnu.org so we can document this accurately" From http://www.gnu.org/software/automake/manual/html_node/List-of-Automake-options.html
Created attachment 259000 [details] [review] tests: Move src/tests to tests and fix make distcheck
Review of attachment 258999 [details] [review]: I've nothing against, though make sure you can create a tarball and it'll be understood by other machine before committing this change. Evolution does't use this, but eds does, so it should be fine.
Review of attachment 259000 [details] [review]: Feel free to commit, but make sure you can create a tarball, same as both 'make dist' and 'make distcheck' will work as expected, with or without disabled tests. ::: tests/Makefile.am @@ +7,3 @@ + -I$(top_builddir)/src \ + -DTEST_FILE_DIR="\"$(top_srcdir)/tests/\"" \ + -DG_LOG_DOMAIN=\"libeews\" \ use a different domain, like "libeews-tests"
Created attachment 259049 [details] [review] Bug #711470 - Move tests from src/tests to test and fix make distcheck
Pushed to the master (3.11.2+)