After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711421 - I get three google docs progress notification popups
I get three google docs progress notification popups
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-11-04 16:45 UTC by Andreas Nilsson
Modified: 2014-03-10 14:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (175.15 KB, image/png)
2013-11-04 16:45 UTC, Andreas Nilsson 		  Details
This patch disconnects the JS signal in the application cleanup function (_clearState). (1.04 KB, patch)
2014-03-09 22:31 UTC, Marta Milakovic 		committed Details | Review

Description Andreas Nilsson 2013-11-04 16:45:48 UTC 
Created attachment 258939 [details]
screenshot

See screenshot.

I added my google account in goa, and documents then popped up 3 of these banners instead of one.

Tested on gnome-continuuos of today.
Comment 1 Allan Day 2013-12-16 09:53:54 UTC 
I also see this (in F20).
Comment 2 Marta Milakovic 2014-03-05 19:00:26 UTC 
I didn't have a case when I see three google docs progress notifications popups. Couple of times happened that I sow two notifications and I would say it happened on WindowModeChanged. Can it be related to window mode change?
Comment 3 Cosimo Cecchi 2014-03-05 21:45:30 UTC 
You should only see one notification of that kind. It's indeed possible that the bug is in the code reacting to a window mode change...
Comment 4 Marta Milakovic 2014-03-09 22:31:57 UTC 
Created attachment 271390 [details] [review]
This patch disconnects the JS signal in the application cleanup function (_clearState).

The service application stays alive with the signal connected and it makes multiple callbacks in sequential instances of gnome-documents.
 
Reconstruct the bug:
Run gnome-documents-service, test by opening and closing the gnome-documents launcher. You should see multiple progress notification widgets displayed without this patch.
Comment 5 Cosimo Cecchi 2014-03-10 14:18:39 UTC 
Thanks for the patch, Marta! It looks good to me, so I committed it to git master on your behalf.
Closing as FIXED.