After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711411 - rtpjitterbuffer: implement RTX statistics
rtpjitterbuffer: implement RTX statistics
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-04 14:40 UTC by Torrie Fischer
Modified: 2013-11-14 10:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtpjitterbuffer: implement rtx statistics (4.29 KB, patch)
2013-11-04 14:41 UTC, Torrie Fischer 		none Details | Review
rtpjitterbuffer: implement rtx statistics (4.17 KB, patch)
2013-11-12 16:20 UTC, Torrie Fischer 		committed Details | Review

Description Torrie Fischer 2013-11-04 14:40:52 UTC 
This patch exposes various RTX statistics to users of the rtpjitterbuffer element
Comment 1 Torrie Fischer 2013-11-04 14:41:35 UTC 
Created attachment 258932 [details] [review]
rtpjitterbuffer: implement rtx statistics
Comment 2 Wim Taymans 2013-11-11 13:46:27 UTC 
I would like to expose these stats with a GstStructure property for the following reasons:

 - it's like the stats of the RTPSource object
 - it allows atomic snapshots of all variables
 - it allows to add more properties later without having to add more properties
Comment 3 Torrie Fischer 2013-11-12 16:20:55 UTC 
Created attachment 259674 [details] [review]
rtpjitterbuffer: implement rtx statistics

Updated to use a GstStructure for jitterbuffer statistics.
Comment 4 Wim Taymans 2013-11-14 08:27:00 UTC 
Improved it a little:


commit b450d31503b794579a7e555eb3ad72e99447873e
Author: Wim Taymans <wim.taymans@gmail.com>
Date:   Thu Nov 14 09:20:06 2013 +0100

    rtpjitterbuffer: rename property to 'stats'
    
    This makes the unit test work.
    We can later also add more stats, not specific to retransmission.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=711411

commit 22ceb80ba92a1b7ea939b10023ff874693d0f554
Author: Torrie Fischer <torrie.fischer@collabora.co.uk>
Date:   Tue Nov 12 11:19:25 2013 -0500

    rtpjitterbuffer: implement rtx statistics