GNOME Bugzilla – Bug 711409
Takes a long time to actually finish
Last modified: 2013-12-12 10:46:07 UTC
When you exit epiphany the window is hidden as expected, but the program is actually running for a while. This is quite confusing an annoying when running epiphany from the command line. I think the search provider should be disabled for ephy private instances. For normal instances, I think the search provider should be implemented in a different binary.
I think it realy good idea. now when I work on epiphany, I must to move to firefox and to kill epiphany before run again from the terminal. Same to gnome-weather, to move the search provider to program with name same to org.gnome.Web.Porvider or something else.
Created attachment 263838 [details] [review] Add a way to create a history service in read only mode
Created attachment 263839 [details] [review] Create the EphyCompletionModel with a history service and bookmarks objects
Created attachment 263840 [details] [review] Move the search provider to its own binary
Created attachment 263843 [details] [review] Remove the headless mode
Review of attachment 263838 [details] [review]: I am still not sure why this is needed at all, but the patch looks OK.
Review of attachment 263840 [details] [review]: ok ::: src/ephy-search-provider-main.c @@ +29,3 @@ + GError *error = NULL; + + if (!ephy_file_helpers_init (NULL, EPHY_FILE_HELPERS_STEAL_DATA, &error)) { I'm confused. Why do you need to steal the data if you're going to use it in read-only mode? ::: src/ephy-search-provider.c @@ +269,2 @@ + /* TODO: Handle the timestamp */ + str = g_strdup_printf ("epiphany %s", uri); This should be gvfs-open. Yes, it was wrong before.
Review of attachment 263843 [details] [review]: Nice!
Review of attachment 263839 [details] [review]: nice
(In reply to comment #6) > Review of attachment 263838 [details] [review]: > > I am still not sure why this is needed at all, but the patch looks OK. Because we don't want the search provider to create the history database if ephy has never been launched, for example. Also I get sqlite errors if we don't do this.
(In reply to comment #7) > Review of attachment 263840 [details] [review]: > > ok > > ::: src/ephy-search-provider-main.c > @@ +29,3 @@ > + GError *error = NULL; > + > + if (!ephy_file_helpers_init (NULL, EPHY_FILE_HELPERS_STEAL_DATA, &error)) { > > I'm confused. Why do you need to steal the data if you're going to use it in > read-only mode? > Because I misunderstood the flag, you are right it doesn't make any sense. > ::: src/ephy-search-provider.c > @@ +269,2 @@ > + /* TODO: Handle the timestamp */ > + str = g_strdup_printf ("epiphany %s", uri); > > This should be gvfs-open. Yes, it was wrong before. I'm not so sure opening something from the history of ephy or an ephy bookmark in another browser is what the user wants. If it was a global history service or bookmarks, it would definitely make sense. In any case, that's a different bug.
Created attachment 263969 [details] [review] Make the history service work even when the database could not be opened The history could be used by the search provider even before the ephy config dir has been created, if epiphany has never been launched. In such case, the methods will simply fail to get results, and the search provider will only return the special case for searching in the web. In this particular case it makes a lot more sense to use the default browser instead of spawning ephy.
Created attachment 263970 [details] [review] Move the search provider to its own binary Updated patch to use the right flags when initializing the file helpers. Also added a FIXME for the default browser to be fixed in a separate bug, this one is about moving the provider to its own binary
Review of attachment 263969 [details] [review]: OK
Review of attachment 263970 [details] [review]: Looks good now.
Pushed to git master, will file new reports for remaining issues
*** Bug 708856 has been marked as a duplicate of this bug. ***