GNOME Bugzilla – Bug 711406
Don’t expose blocked BlueZ devices as persona stores
Last modified: 2013-11-06 14:50:53 UTC
If a BlueZ device’s Blocked property is true, all incoming connections from it will be rejected by BlueZ. Accordingly, folks shouldn’t try and use it as a persona store. Patch coming.
Created attachment 258928 [details] [review] bluez: Prevent blocked Bluetooth devices from becoming persona stores If the user has explicitly blocked a Bluetooth phone from their laptop, they don’t want to try downloading contacts from it.
I don't know much about the bluez backend, but it seems to makes sense.
Review of attachment 258928 [details] [review]: ::: backends/bluez/bluez-backend.vala @@ +241,3 @@ /* Sometimes the UUIDs property only changes a second or two after * the device first appears, so try adding the device again. */ + if (device.paired == true && device.blocked == false && I'd have said "if (device.paired && !device.blocked" but if this is your coding style, fine.
Review of attachment 258928 [details] [review]: a-c_n
Comment on attachment 258928 [details] [review] bluez: Prevent blocked Bluetooth devices from becoming persona stores commit c2b005182b114769a768890642d6302bd669f981 Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Mon Nov 4 14:09:34 2013 +0000 bluez: Prevent blocked Bluetooth devices from becoming persona stores If the user has explicitly blocked a Bluetooth phone from their laptop, they don’t want to try downloading contacts from it. https://bugzilla.gnome.org/show_bug.cgi?id=711406 NEWS | 1 + backends/bluez/bluez-backend.vala | 21 +++++++++++++++++---- 2 files changed, 18 insertions(+), 4 deletions(-)