After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711382 - New dark photorealistic logo icon
New dark photorealistic logo icon
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: Build and packaging
Git
Other Linux
: Normal enhancement
: 0.93
Assigned To: Jakub Steiner
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-04 09:30 UTC by Jean-François Fortin Tam
Modified: 2013-12-12 20:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshots of how the 128² size renders in GNOME Shell (244.50 KB, application/x-tar)
2013-12-06 21:15 UTC, Jean-François Fortin Tam
Details

Description Jean-François Fortin Tam 2013-11-04 09:30:06 UTC
Jakub has been kind enough to spend time redoing the Pitivi logo icon in a photorealistic way with Blender. It comes in all sizes including the humongous 512x512 version, though we depend on https://bugs.freedesktop.org/show_bug.cgi?id=69231 for that so his current patch only uses the 256² version.

His patch is here:
http://jimmac.musichall.cz/stuff/0001-Update-the-app-icon.patch

Unfortunately I haven't had the time to test it and merge it for the 0.92 cycle, but this should happen eventually. If someone would like to test it, I want to know about the following:

- Make check && make distcheck   pass
- The resulting tarball has all the icons
- Installing systemwide from the resulting tarball installs all the icons
- I would like to see a screenshot of how this looks in GNOME Shell.
  A potential issue I noted is the use of diagonal lines causing aliasing
  problems when the 512² or 256² version is scaled to 128², be it by browsers
  or by GIMP.

Currently, the first iteration of the patch mentioned above has some errors somewhere related to makefiles, I think it tries to look for the 512 version, not sure if it checks for 256 (as said, I unfortunately hadn't had time to inspect this properly so far).
Comment 1 Jean-François Fortin Tam 2013-11-04 16:54:11 UTC
Oh yeah, and this is the initial smoke test I did:

    git am <0001-Update-the-app-icon.patch
    make clean && ./autogen.sh && make

When you inspect the output you have:

> checking build system type... data/icons/Makefile.am:1: error:
> required directory data/icons/512x512 does not exist


Relatively minor to fix/amend, but it means I haven't yet had the opportunity to review the rest of the items I listed in the description above, and thus to see if there are other gotchas awaiting us.
Comment 2 Jakub Steiner 2013-12-06 19:17:45 UTC
Sorry for the broken Makefile. I've updated the patch to include the 512, still the same URL (can't attach to bugzilla due to filesize):

http://jimmac.musichall.cz/stuff/0001-Update-the-app-icon.patch
Comment 3 Jean-François Fortin Tam 2013-12-06 21:15:40 UTC
Created attachment 263701 [details]
screenshots of how the 128² size renders in GNOME Shell

Hi Jakub, thanks for taking the time to correct your patch, much appreciated :)
I gave it a try with a "make install" in prefix=/usr (just assuming that this will behave the same with tarballs etc.) and took these screenshots (attached) of how it looks like in GNOME Shell 3.10.

It seems like the diagonal lines aliasing issue, while still a bit apparent, is much better than how it initially looked like in web browsers' or GIMP's rendering/resizing.

Take a look at those screenshots and decide if this is something you wish to address or if it satisfies your tastes. If it's good enough for you, then I'd probably take your updated patch and push it "as is".
Comment 4 Jean-François Fortin Tam 2013-12-12 20:06:50 UTC
Pushed as:

commit 2e56e51d14621d2b502788941657b860f0725bf3
Author: Jakub Steiner <jimmac@gmail.com>
Date:   Fri Oct 11 17:05:15 2013 +0200

    Update the app icon
    
    - part of the gnome goal:
      https://wiki.gnome.org/GnomeGoals/HighResolutionAppIcons
    
    https://bugzilla.gnome.org/show_bug.cgi?id=711382


Thanks so much Jakub!