After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711368 - plugin-appstream: Return FALSE if we set GError
plugin-appstream: Return FALSE if we set GError
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-11-04 00:23 UTC by Colin Walters
Modified: 2013-11-05 00:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
plugin-appstream: Return FALSE if we set GError (1.04 KB, patch)
2013-11-04 00:23 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2013-11-04 00:23:26 UTC 
Side note: an OSTree-like rigorous coding style where ret = FALSE
always at the start of a function would make this error setting errors
not happen.
Comment 1 Colin Walters 2013-11-04 00:23:30 UTC 
Created attachment 258892 [details] [review]
plugin-appstream: Return FALSE if we set GError
Comment 2 Matthias Clasen 2013-11-05 00:03:25 UTC 
Review of attachment 258892 [details] [review]:

sure
Comment 3 Colin Walters 2013-11-05 00:14:14 UTC 
Attachment 258892 [details] pushed as 9a7e11d - plugin-appstream: Return FALSE if we set GError