GNOME Bugzilla – Bug 711327
Replaced Game Menu with ToggleButton/TreeView for puzzles list
Last modified: 2013-11-04 04:11:05 UTC
Created attachment 258847 [details] [review] The patch Replaced the Game menu with a TreeView. The visibility of the TreeView is toggled by a ToggleToolButton in the windows main toolbar. A menu strip for a single menu seemed redundant and unattractive. This new solution is intended to be more intuitive.
Created attachment 258860 [details] Demonstrates issue with bolded elements There is some odd behavior regarding the bolded menu elements. Presumably the currently-selected map is supposed to be bold, but using the Next Puzzle and Previous Puzzle buttons do not affect this, so the bold element forever remains the initial map when using these buttons (screenshot attached below). When not using the buttons, I wind up with multiple elements bolded at the same time, which become unbolded after an odd delay (video attached here).
Created attachment 258861 [details] Demonstrates issue with bolded elements after using previous/next buttons Here the bold map is Shark, yet the current map is Ithaca. After some uncertain amount of time, Shark was unboldened and Ithaca became bold.
Created attachment 258871 [details] [review] Updated patch. This problem isn't present when I run the application. I would guess that the draw event isn't being processed until some time latter. This updated patch should force all UI events to be processed before continuing. Could you please test and let me know if it works.
Review of attachment 258871 [details] [review]: Well the updated patch didn't help at all. Then I rebuilt all the dependencies and the problem fixed itself, so the first version of the patch was fine. Sorry about that. One last comment: could we swap the Next and Previous buttons, unless there's a reason for their current relative positions? I'm mentally replacing the word Previous with a left arrow, and the word Next with a right arrow. Feel free to push this if you can, otherwise I'll do so. Thanks again!
Created attachment 258896 [details] [review] Replaced puzzles list with Treeview. I have swapped the buttons around and removed the UI poll. I don't have permission to push commits so I would be grateful if you could push it, thanks.
Great, thanks!