Created attachment 258817 [details] [review]
GsmProcessHelper: Port to GSubprocess

Attachment 258817 [details] pushed as bee8fa3 - GsmProcessHelper: Port to GSubprocess

IRC review for posterity:

<halfline_laptop> walters: does helper.error ever get propagated to the caller of gsmproceshelper ?
<walters> halfline_laptop: ah hah, good catch.  Needs:

+        helper.error = error;

<halfline_laptop> walters: it's a little weird to use GError ** in a structure
<halfline_laptop> i probably would have used a GError *
<halfline_laptop> but meh
<halfline_laptop> push if you've tested it and it works
<walters> halfline_laptop: i go back and forth on whether the async impl of a sync operaton should have its own error that's propagated, or merely point to an existing error