After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711226 - Skip Haze's IRC implementation
Skip Haze's IRC implementation
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: tp-aw
3.10.x
Other All
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-31 18:42 UTC by Debarshi Ray
Modified: 2013-11-14 14:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
protocol: skip Haze's IRC implementation (1.25 KB, patch)
2013-10-31 18:43 UTC, Debarshi Ray 		none Details | Review
protocol: skip Haze's IRC implementation (1.27 KB, patch)
2013-11-01 10:08 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2013-10-31 18:42:28 UTC 
Empathy advertises IRC support in when creating a new account in empathy-accounts even when telepathy-idle is not present. It crashes immediately afterwards when the user tries to use the presented interface.

I think we should be skipping Haze's IRC implementation, just as we explicitly skip its "facebook", "irc" and "sip" implementations.
Comment 1 Debarshi Ray 2013-10-31 18:43:36 UTC 
Created attachment 258682 [details] [review]
protocol: skip Haze's IRC implementation
Comment 2 Marco Barisione 2013-11-01 07:56:01 UTC 
Hm, I didn't even know tp-aw would try to use haze for IRC. For me the patch is fine, I will just ping Guillaume to make sure he agrees too as we are removing a feature (even if broken).

Just one thing, could you please add this bug number in the patch like we did for sip?
Comment 3 Debarshi Ray 2013-11-01 10:08:27 UTC 
Created attachment 258723 [details] [review]
protocol: skip Haze's IRC implementation
Comment 4 Debarshi Ray 2013-11-01 11:59:58 UTC 
(In reply to comment #0)
> I think we should be skipping Haze's IRC implementation, just as we explicitly
> skip its "facebook", "irc" and "sip" implementations.

This should have been: "... skip its "facebook" and "sip" implementations.

Sorry for the typo.
Comment 5 Guillaume Desmottes 2013-11-04 07:52:47 UTC 
Yep that's fine with me, I assumed we were already doing that actually.
Comment 6 Debarshi Ray 2013-11-14 14:21:39 UTC 
Comment on attachment 258723 [details] [review]
protocol: skip Haze's IRC implementation

Thanks for the review.