After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711168 - When clicking to add a keyframe, the keyframe gets created a few pixels lower than the actual mouse cursor position
When clicking to add a keyframe, the keyframe gets created a few pixels lower...
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: Keyframes animation
0.91
Other Linux
: Normal minor
: 0.93
Assigned To: Alex Băluț
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-30 17:44 UTC by Jean-François Fortin Tam
Modified: 2014-03-14 17:32 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jean-François Fortin Tam 2013-10-30 17:44:47 UTC
This is quite annoying as it is impossible to create a "line" of keyframes, they always get shifted/drifted downwards everytime you create one, so there is no precision in creating keyframes.

Possibly affects keyframe deletion too.
Comment 1 Alex Băluț 2014-02-28 21:53:14 UTC
This partially fixes this bug:

commit 54408036318a624b4ccade928dcc4fdbe93b74b9
Author: Alexandru Băluț <alexandru.balut@gmail.com>
Date:   Wed Feb 26 17:57:21 2014 +0100

    elements: Fix video clips keyframes and lines vertical position
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=711168


Another commit should make sure that when a keyframe is created by clicking a line, only the x coordinate of the click event is considered, with y being calculated from the two points defining the clicked line and the x of the click event. Otherwise, given the fact that the line has a width of a few pixels, the keyframe is not created on the line but possibly a bit upper or lower.
Comment 2 Jean-François Fortin Tam 2014-03-01 16:20:12 UTC
The current behavior after your commit is already a very nice improvement, thanks Alex! I guess you're leaving this open/assigned for now because you want to continue with what you've proposed in your comment.
Comment 3 Alex Băluț 2014-03-14 17:32:51 UTC
commit 0ff3bae5cebfac877fb4a567703e6b00ddd1bd1c
Author: Alexandru Băluț <alexandru.balut@gmail.com>
Date:   Sat Mar 1 14:59:41 2014 +0100

    elements: Make sure the line remains straight when adding a keyframe when clicked
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=711168