After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711158 - gtktextattributes: Use an anonymous union instead of arch-testing #ifdef
gtktextattributes: Use an anonymous union instead of arch-testing #ifdef
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-10-30 15:27 UTC by Colin Walters
Modified: 2013-11-13 18:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtktextattributes: Use an anonymous union instead of arch-testing #ifdef (976 bytes, patch)
2013-10-30 15:27 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2013-10-30 15:27:19 UTC 
See https://bugzilla.gnome.org/show_bug.cgi?id=711153
Comment 1 Colin Walters 2013-10-30 15:27:21 UTC 
Created attachment 258593 [details] [review]
gtktextattributes: Use an anonymous union instead of arch-testing #ifdef
Comment 2 Matthias Clasen 2013-11-01 15:34:01 UTC 
Review of attachment 258593 [details] [review]:

ok
Comment 3 Colin Walters 2013-11-03 16:16:50 UTC 
Ok, let's see if anyone complains...

Attachment 258593 [details] pushed as c9892df - gtktextattributes: Use an anonymous union instead of arch-testing #ifdef
Comment 4 Colin Walters 2013-11-13 18:07:47 UTC 
Apparently this causes old versions of gcc to blow up unless -fms-extensions is provided.  Specifically one downstream user wanted to use an old version of GCC targeting an embedded architecture.

GTK+ can continue to build with these versions of GCC if -fms-extensions is provided.


Anyways, see follow up here:
https://git.gnome.org/browse/gtk+/commit/?id=3c6c90086fe3507563abdd1d511e6f264d131572