After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711110 - GDK_HINT_MAX_SIZE ignored on Win32
GDK_HINT_MAX_SIZE ignored on Win32
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
2.24.x
Other Windows
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-10-29 22:56 UTC by Benjamin Gilbert
Modified: 2013-10-31 21:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix by moving the default values into an else block. (802 bytes, patch)
2013-10-31 20:47 UTC, Cody Russell 		committed Details | Review

Description Benjamin Gilbert 2013-10-29 22:56:20 UTC 
gtk version: 2.24.21

Setting a maximum window size via gtk_window_set_geometry_hints() does not work on Windows.  The problem appears to be in the gdk_event_translate() WM_GETMINMAXINFO handler.  It properly checks for the GDK_HINT_MAX_SIZE hint flag and sets mmi->ptMaxTrackSize, but then clobbers it with a hardcoded value of (30000, 30000).  This behavior was introduced by commit 4f9e1dd4, whose log message claims to be changing the *default* maximum size, but in fact it's overriding the maximum size in all cases.

It appears that the gdk_event_translate() implementation in Git master behaves the same way, though I haven't tested it.
Comment 1 Cody Russell 2013-10-31 20:47:23 UTC 
Created attachment 258687 [details] [review]
Fix by moving the default values into an else block.
Comment 2 Cody Russell 2013-10-31 20:57:35 UTC 
Fixed in master 46fbefe79504f288d89d376940e3ae514b233951
Comment 3 Cody Russell 2013-10-31 20:59:11 UTC 
Cherry-picked over to gtk-2-24 branch 280fc402be5fb46b66bcd32056963bb1afb8b54b