After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711103 - gmessages: Add g_info macro for G_LOG_LEVEL_INFO
gmessages: Add g_info macro for G_LOG_LEVEL_INFO
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
: 526804 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-10-29 20:32 UTC by Stef Walter
Modified: 2013-11-19 22:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gmessages: Add g_info macro for G_LOG_LEVEL_INFO (4.53 KB, patch)
2013-10-29 20:32 UTC, Stef Walter 		committed Details | Review

Description Stef Walter 2013-10-29 20:32:08 UTC 
This patch adds a macro for g_info(), alongside g_message(),
g_debug() and friends.

Other projects want to use this log level (especially when log levels
errors to syslog priorities), and end up having to define this
awkwardly.
Comment 1 Stef Walter 2013-10-29 20:32:11 UTC 
Created attachment 258484 [details] [review]
gmessages: Add g_info macro for G_LOG_LEVEL_INFO

For completeness. Although less used than others, projects want
to use this, and end up having to define it awkwardly themselves.
Comment 2 Marc-Andre Lureau 2013-10-30 12:19:09 UTC 
dup of 526804 ?
Comment 3 Stef Walter 2013-10-30 12:43:06 UTC 
(In reply to comment #2)
> dup of 526804 ?

Indeed, I should have checked for dups. Although the attached patch is rebased for modern glib, and has a bit more in it.

I hope it's okay if I mark that one a duplicate of this one.
Comment 4 Stef Walter 2013-10-30 12:43:16 UTC 
*** Bug 526804 has been marked as a duplicate of this bug. ***
Comment 5 Colin Walters 2013-11-18 18:07:29 UTC 
Review of attachment 258484 [details] [review]:

Looks good to me.

::: glib/tests/protocol.c
@@ -45,3 @@
-#ifdef g_info
-#error "rewrite this to use g_info()"
-#endif

Hah, funny.
Comment 6 Juan Pablo Ugarte 2013-11-18 19:38:08 UTC 
(In reply to comment #3)
> (In reply to comment #2)
> > dup of 526804 ?
> 
> Indeed, I should have checked for dups. Although the attached patch is rebased
> for modern glib, and has a bit more in it.
> 
> I hope it's okay if I mark that one a duplicate of this one.

ohh no, you destroyed my first attempt to contribute to glib!

haha
Comment 7 Colin Walters 2013-11-18 20:00:21 UTC 
(In reply to comment #6)
>
> ohh no, you destroyed my first attempt to contribute to glib!

Sorry about that =(  In the last few years GLib (and more of GNOME) has gotten better about patch review, so I hope you'll have better luck with future patches!
Comment 8 Stef Walter 2013-11-19 07:15:05 UTC 
Attachment 258484 [details] pushed as 36f1a4c - gmessages: Add g_info macro for G_LOG_LEVEL_INFO
Comment 9 Juan Pablo Ugarte 2013-11-19 22:58:14 UTC 
(In reply to comment #7)
> (In reply to comment #6)
> >
> > ohh no, you destroyed my first attempt to contribute to glib!
> 
> Sorry about that =(  In the last few years GLib (and more of GNOME) has gotten
> better about patch review, so I hope you'll have better luck with future
> patches!

Please do not be!, I was kidding