After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711081 - handle color escapes better
handle color escapes better
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-29 15:42 UTC by William Jon McCann
Modified: 2016-02-10 04:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (15.04 KB, image/png)
2013-10-29 15:42 UTC, William Jon McCann 		  Details
room: Strip color codes from status messages (2.19 KB, patch)
2013-10-29 17:52 UTC, Florian Müllner 		committed Details | Review

Description William Jon McCann 2013-10-29 15:42:14 UTC 
Created attachment 258449 [details]
screenshot

We don't seem to handle IRC color escapes (http://www.mirc.com/colors.html) very well at the moment.
Comment 1 Florian Müllner 2013-10-29 17:52:43 UTC 
Created attachment 258468 [details] [review]
room: Strip color codes from status messages

Parts of status messages (leave/quit) are under user control and
may contain fancy color codes as supported by some clients. We
are not one of them (and probably shouldn't be one either), but
displaying raw escape sequences looks clearly broken, so strip
them out.
Comment 2 Florian Müllner 2013-10-29 17:53:19 UTC 
Attachment 258468 [details] pushed as d7c4a0a - room: Strip color codes from status messages