After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711015 - Add msearch-port property to GSSDPClient
Add msearch-port property to GSSDPClient
Status: RESOLVED FIXED
Product: gssdp
Classification: Other
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-28 14:41 UTC by Jens Georg
Modified: 2019-02-22 09:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add msearch-port property to GSSDPClient (8.88 KB, patch)
2013-10-28 14:41 UTC, Jens Georg 		none Details | Review
Add msearch-port property to GSSDPClient (8.88 KB, patch)
2013-10-29 12:35 UTC, Jens Georg 		committed Details | Review
Propagate port property to GSSDPClient (2.59 KB, patch)
2013-10-29 12:35 UTC, Jens Georg 		committed Details | Review

Description Jens Georg 2013-10-28 14:41:14 UTC 
Make it possible to use a fixed port for SSDP M-SEARCH requests.
Comment 1 Jens Georg 2013-10-28 14:41:22 UTC 
Created attachment 258310 [details] [review]
Add msearch-port property to GSSDPClient
Comment 2 Krzesimir Nowak 2013-10-29 06:44:56 UTC 
Review of attachment 258310 [details] [review]:

Typos.

::: libgssdp/gssdp-client.c
@@ +547,3 @@
+         * UDP port to use for sending multicast M-SEARCH requests on the
+         * network. If not set (or set to 0) a random port will be used.
+         * This property can be only set durinc object construction.

s/durinc/during

@@ +616,3 @@
+ * @msearch_port: The network port to use for M-SEARCH requests or 0 for
+ * random.
+ * @error: (allow-none): Location to store error, or %NULL

missing dot.
Comment 3 Jens Georg 2013-10-29 12:35:28 UTC 
Created attachment 258439 [details] [review]
Add msearch-port property to GSSDPClient
Comment 4 Jens Georg 2013-10-29 12:35:51 UTC 
Created attachment 258440 [details] [review]
Propagate port property to GSSDPClient

GSSDPClient introduced a new msearch-port property that this patch sets from
the port property in GUPnPContext.
Comment 5 Jens Georg 2013-10-29 12:36:33 UTC 
The proper solution would be to move the "port" property to GSSDPClient, but that has all kind of implications :-/
Comment 6 Jens Georg 2013-10-29 15:14:55 UTC 
Comment on attachment 258439 [details] [review]
Add msearch-port property to GSSDPClient

Attachment 258439 [details] pushed as fe85ede - Add msearch-port property to GSSDPClient
Comment 7 Jens Georg 2013-10-29 15:19:29 UTC 
Attachment 258440 [details] pushed as b8f2cbf - Propagate port property to GSSDPClient