After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710993 - Filesystem is marked readonly but it isn't
Filesystem is marked readonly but it isn't
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: recent backend
git master
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-28 09:43 UTC by Ross Lagerwall
Modified: 2013-10-31 19:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
recent: Don't mark filesystem as read-only (1.01 KB, patch)
2013-10-28 09:45 UTC, Ross Lagerwall
none Details | Review

Description Ross Lagerwall 2013-10-28 09:43:23 UTC
Since items can be deleted from the recent backend, the filesystem should not be marked read-only.
Comment 1 Ross Lagerwall 2013-10-28 09:45:00 UTC
Created attachment 258276 [details] [review]
recent: Don't mark filesystem as read-only

The filesystem should not be marked as read-only since items can be
deleted from it.
Comment 2 Bastien Nocera 2013-10-28 10:27:40 UTC
New items cannot be created though, and there should probably be a way to communicate that.
Comment 3 Ross Lagerwall 2013-10-28 10:51:50 UTC
(In reply to comment #2)
> New items cannot be created though, and there should probably be a way to
> communicate that.

Isn't that communicated by the attribute "access::can-write: FALSE" on recent:/// ?

The trash backend seems pretty similar and *doesn't* set the filesystem to readonly.
Comment 4 Bastien Nocera 2013-10-28 10:54:59 UTC
Fair enough.
Comment 5 Ross Lagerwall 2013-10-31 19:49:48 UTC
Pushed to master as 154a57ca. Thanks!