After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710987 - g_return_if_fail used even if function requires return value
g_return_if_fail used even if function requires return value
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other Mac OS
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-10-28 08:24 UTC by Daniel Svensson
Modified: 2013-10-29 21:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix it! (2.08 KB, patch)
2013-10-28 08:32 UTC, Daniel Svensson 		committed Details | Review

Description Daniel Svensson 2013-10-28 08:24:26 UTC 
g_return_if_fail used even if function requires return value, should be replaced by g_return_val_if_fail. This fails on Mac OS X at least, and probably fails with clang on Linux too.
Comment 1 Daniel Svensson 2013-10-28 08:32:23 UTC 
Created attachment 258269 [details] [review]
fix it!
Comment 2 Daniel Svensson 2013-10-28 18:30:42 UTC 
can also be cherry-picked straight from https://github.com/dsvensson/gtk/commit/5299057c66aab64a30835c0e44734a4abae4ab5a if that's easier.