GNOME Bugzilla – Bug 710984
misc patch to improve MSVC compatibility and CMake build script
Last modified: 2014-05-30 05:15:32 UTC
I'm trying to implement some element based on opengl plugin on win32, but I found the CMake build script incomplete ,VS project out of date and some headers not compatible with msvc , so I made some patch to complete the CMake build script, hopes this can help others working with msvc. this script can also build in Linux ,but not behave exactly the same as autoconf. it lacks automatic config header generation , use pre-defined header instead. tested on win7 32 bit. the FindGstreamer.cmake file included in patch can also be used to found Gstreamer gl plugin with cmake. these patch not the same as I posted in mail list. since I found some small bug in it, so I did some fix and re-format it.
Created attachment 258263 [details] [review] 0001-improve-CMake-build-system
Created attachment 258264 [details] [review] 0002-improve-MSVC-vc10-compatibility
Created attachment 258265 [details] [review] 0003-improve-cmake-build-script-add-install-target
Review of attachment 258264 [details] [review]: ::: gst-libs/gst/gl/gstglapi.h @@ +47,3 @@ # include <GL/gl.h> # include <GL/glu.h> +# if defined(__WIN32__) || defined(_WIN32) Just use #if defined(G_OS_WIN32) here ::: gst/gl/gstglmosaic.c @@ +263,2 @@ + /* *INDENT-OFF* */ + GLfloat temp[]= Just move GLFloat *v_vertices here and initialize it with {} directly instead of introducing a new variable
Comment on attachment 258263 [details] [review] 0001-improve-CMake-build-system Please provide your real name for the patch
Comment on attachment 258265 [details] [review] 0003-improve-cmake-build-script-add-install-target Please provide your real name for the patch
(In reply to comment #6) > (From update of attachment 258265 [details] [review]) > Please provide your real name for the patch Sorry for my slow reponse, I'm busy working on my office work...I'm 王昕宇(Wang Xinyu). Thank you for reviewing.
plus: I found the compiled dll does not export necessary functions (needs some additional steps),so it can not be linked to , but the opengl elements in dll can work with no problem. hopes further improve
Hi, the opengl library/plugins are now included in the larger set of gst-plugins-bad, whose build system does not support cmake files. The recommended way of building on windows os's is through the cerbero build system (http://cgit.freedesktop.org/gstreamer/cerbero). Let us know of any other bugs you find :).