After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710919 - Telepathy-account-widgets has an incomplete .pc file
Telepathy-account-widgets has an incomplete .pc file
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: tp-aw
3.6.x
Other Linux
: High critical
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-26 13:12 UTC by Sjoerd Simons
Modified: 2013-12-27 15:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (823 bytes, patch)
2013-10-26 13:12 UTC, Sjoerd Simons
none Details | Review
pc: add gudev and cheese as Requires if needed (2.20 KB, patch)
2013-11-29 14:49 UTC, Guillaume Desmottes
none Details | Review

Description Sjoerd Simons 2013-10-26 13:12:54 UTC
Created attachment 258175 [details] [review]
Proposed patch

When building empathy with LDFLAGS="-Wl,-z,defs -Wl,-O1 -Wl,--as-needed" it explodes as the tp-aw .a wants to link against cheese & gudev while empathy's cflags/ldflags don't. Adding cheese/gudev to the .pc file of tp-aw fixes that properly..

Attached is a straw-men patch for this,most likely it wants some tweaking in case tp-aw isn't build with cheese/gudev support
Comment 1 Guillaume Desmottes 2013-11-29 14:49:16 UTC
Created attachment 263127 [details] [review]
pc: add gudev and cheese as Requires if needed
Comment 2 Marco Barisione 2013-11-30 09:54:26 UTC
Look good to me!
Comment 3 Guillaume Desmottes 2013-12-27 15:32:12 UTC
Merged to master.