GNOME Bugzilla – Bug 710878
gjs cpp port
Last modified: 2013-10-29 02:47:28 UTC
This is a prerequisite for js24
Created attachment 258119 [details] [review] build: rename all c file to cpp
Created attachment 258120 [details] [review] build: update makefiles to build using C++ Makefile: use CXX Warning flags
Created attachment 258121 [details] [review] fix declaration of JSClasses
Created attachment 258122 [details] [review] update to c++ api for JSHandle* Objects
Created attachment 258123 [details] [review] update to c++ api for fop->runtime()
Created attachment 258124 [details] [review] param.cpp fix jump over value initialisation
Created attachment 258125 [details] [review] fix unkown size of proto_props
Created attachment 258126 [details] [review] build: fix implicit pointer conversion errors
Created attachment 258361 [details] [review] build: rename all c file to cpp
Created attachment 258362 [details] [review] build: update makefiles to build using C++
Created attachment 258363 [details] [review] fix declaration of JSClasses to be valid c++ syntax
Created attachment 258364 [details] [review] update to c++ types and api for JSHandle* Objects squased in one more C++ only patch from the js24 branch
Created attachment 258365 [details] [review] update to c++ api for fop->runtime()
Created attachment 258366 [details] [review] param.cpp fix jump over value initialisation
Created attachment 258367 [details] [review] fix invalid syntax on proto_props resulting in unknown size errors
Created attachment 258368 [details] [review] build: fix implicit pointer conversion errors
Review of attachment 258366 [details] [review]: ::: gi/param.cpp @@ +131,3 @@ } + if (!gjs_value_from_g_argument(context, value_p.address(), type_info, &arg, TRUE)) seems like an unrelated fix? bad rebase?
rest of these look fine.
Created attachment 258370 [details] [review] build: rename all c file to cpp
Created attachment 258371 [details] [review] build: update makefiles to build using C++
Created attachment 258372 [details] [review] fix declaration of JSClasses to be valid c++ syntax
Created attachment 258373 [details] [review] update to c++ types and api for JSHandle* Objects
Created attachment 258374 [details] [review] update to c++ api for fop->runtime()
Created attachment 258375 [details] [review] param.cpp fix jump over value initialisation
Created attachment 258376 [details] [review] fix invalid syntax on proto_props resulting in unknown size errors
Created attachment 258377 [details] [review] build: fix implicit pointer conversion errors
yes bad rebase, moved into the correct patch now (the JSHandles* one)
looks fine, go ahead and push
Attachment 258370 [details] pushed as 361f0b9 - build: rename all c file to cpp Attachment 258371 [details] pushed as 7a88ac3 - build: update makefiles to build using C++ Attachment 258372 [details] pushed as e70b125 - fix declaration of JSClasses to be valid c++ syntax Attachment 258373 [details] pushed as 9daff9c - update to c++ types and api for JSHandle* Objects Attachment 258374 [details] pushed as d84c53a - update to c++ api for fop->runtime() Attachment 258375 [details] pushed as 5c110be - param.cpp fix jump over value initialisation Attachment 258376 [details] pushed as 13150fe - fix invalid syntax on proto_props resulting in unknown size errors Attachment 258377 [details] pushed as 4d55582 - build: fix implicit pointer conversion errors