After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710878 - gjs cpp port
gjs cpp port
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-25 13:56 UTC by darkxst
Modified: 2013-10-29 02:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: rename all c file to cpp (15.28 KB, patch)
2013-10-25 13:58 UTC, darkxst
none Details | Review
build: update makefiles to build using C++ (9.25 KB, patch)
2013-10-25 13:58 UTC, darkxst
none Details | Review
fix declaration of JSClasses (8.45 KB, patch)
2013-10-25 13:58 UTC, darkxst
none Details | Review
update to c++ api for JSHandle* Objects (6.28 KB, patch)
2013-10-25 13:58 UTC, darkxst
none Details | Review
update to c++ api for fop->runtime() (1.23 KB, patch)
2013-10-25 13:58 UTC, darkxst
none Details | Review
param.cpp fix jump over value initialisation (1.23 KB, patch)
2013-10-25 13:58 UTC, darkxst
none Details | Review
fix unkown size of proto_props (18.00 KB, patch)
2013-10-25 13:58 UTC, darkxst
none Details | Review
build: fix implicit pointer conversion errors (71.83 KB, patch)
2013-10-25 13:58 UTC, darkxst
none Details | Review
build: rename all c file to cpp (15.28 KB, patch)
2013-10-28 23:47 UTC, darkxst
none Details | Review
build: update makefiles to build using C++ (9.22 KB, patch)
2013-10-28 23:47 UTC, darkxst
none Details | Review
fix declaration of JSClasses to be valid c++ syntax (8.47 KB, patch)
2013-10-28 23:47 UTC, darkxst
none Details | Review
update to c++ types and api for JSHandle* Objects (9.14 KB, patch)
2013-10-28 23:47 UTC, darkxst
none Details | Review
update to c++ api for fop->runtime() (1.23 KB, patch)
2013-10-28 23:47 UTC, darkxst
none Details | Review
param.cpp fix jump over value initialisation (1.23 KB, patch)
2013-10-28 23:48 UTC, darkxst
needs-work Details | Review
fix invalid syntax on proto_props resulting in unknown size errors (18.04 KB, patch)
2013-10-28 23:48 UTC, darkxst
none Details | Review
build: fix implicit pointer conversion errors (71.83 KB, patch)
2013-10-28 23:48 UTC, darkxst
none Details | Review
build: rename all c file to cpp (15.28 KB, patch)
2013-10-29 00:21 UTC, darkxst
committed Details | Review
build: update makefiles to build using C++ (9.21 KB, patch)
2013-10-29 00:21 UTC, darkxst
committed Details | Review
fix declaration of JSClasses to be valid c++ syntax (8.47 KB, patch)
2013-10-29 00:21 UTC, darkxst
committed Details | Review
update to c++ types and api for JSHandle* Objects (9.15 KB, patch)
2013-10-29 00:21 UTC, darkxst
committed Details | Review
update to c++ api for fop->runtime() (1.23 KB, patch)
2013-10-29 00:22 UTC, darkxst
committed Details | Review
param.cpp fix jump over value initialisation (947 bytes, patch)
2013-10-29 00:22 UTC, darkxst
committed Details | Review
fix invalid syntax on proto_props resulting in unknown size errors (18.04 KB, patch)
2013-10-29 00:22 UTC, darkxst
committed Details | Review
build: fix implicit pointer conversion errors (71.83 KB, patch)
2013-10-29 00:22 UTC, darkxst
committed Details | Review

Description darkxst 2013-10-25 13:56:56 UTC
This is a prerequisite for js24
Comment 1 darkxst 2013-10-25 13:58:14 UTC
Created attachment 258119 [details] [review]
build: rename all c file to cpp
Comment 2 darkxst 2013-10-25 13:58:17 UTC
Created attachment 258120 [details] [review]
build: update makefiles to build using C++

Makefile: use CXX Warning flags
Comment 3 darkxst 2013-10-25 13:58:21 UTC
Created attachment 258121 [details] [review]
fix declaration of JSClasses
Comment 4 darkxst 2013-10-25 13:58:24 UTC
Created attachment 258122 [details] [review]
update to c++ api for JSHandle* Objects
Comment 5 darkxst 2013-10-25 13:58:27 UTC
Created attachment 258123 [details] [review]
update to c++ api for fop->runtime()
Comment 6 darkxst 2013-10-25 13:58:31 UTC
Created attachment 258124 [details] [review]
param.cpp fix jump over value initialisation
Comment 7 darkxst 2013-10-25 13:58:35 UTC
Created attachment 258125 [details] [review]
fix unkown size of proto_props
Comment 8 darkxst 2013-10-25 13:58:38 UTC
Created attachment 258126 [details] [review]
build: fix implicit pointer conversion errors
Comment 9 darkxst 2013-10-28 23:47:01 UTC
Created attachment 258361 [details] [review]
build: rename all c file to cpp
Comment 10 darkxst 2013-10-28 23:47:07 UTC
Created attachment 258362 [details] [review]
build: update makefiles to build using C++
Comment 11 darkxst 2013-10-28 23:47:15 UTC
Created attachment 258363 [details] [review]
fix declaration of JSClasses to be valid c++ syntax
Comment 12 darkxst 2013-10-28 23:47:53 UTC
Created attachment 258364 [details] [review]
update to c++ types and api for JSHandle* Objects

squased in one more C++ only patch from the js24 branch
Comment 13 darkxst 2013-10-28 23:47:59 UTC
Created attachment 258365 [details] [review]
update to c++ api for fop->runtime()
Comment 14 darkxst 2013-10-28 23:48:06 UTC
Created attachment 258366 [details] [review]
param.cpp fix jump over value initialisation
Comment 15 darkxst 2013-10-28 23:48:12 UTC
Created attachment 258367 [details] [review]
fix invalid syntax on proto_props resulting in unknown size errors
Comment 16 darkxst 2013-10-28 23:48:18 UTC
Created attachment 258368 [details] [review]
build: fix implicit pointer conversion errors
Comment 17 Jasper St. Pierre (not reading bugmail) 2013-10-29 00:01:27 UTC
Review of attachment 258366 [details] [review]:

::: gi/param.cpp
@@ +131,3 @@
     }
 
+    if (!gjs_value_from_g_argument(context, value_p.address(), type_info, &arg, TRUE))

seems like an unrelated fix? bad rebase?
Comment 18 Jasper St. Pierre (not reading bugmail) 2013-10-29 00:01:56 UTC
Review of attachment 258366 [details] [review]:

::: gi/param.cpp
@@ +131,3 @@
     }
 
+    if (!gjs_value_from_g_argument(context, value_p.address(), type_info, &arg, TRUE))

seems like an unrelated fix? bad rebase?
Comment 19 Jasper St. Pierre (not reading bugmail) 2013-10-29 00:03:19 UTC
rest of these look fine.
Comment 20 darkxst 2013-10-29 00:21:41 UTC
Created attachment 258370 [details] [review]
build: rename all c file to cpp
Comment 21 darkxst 2013-10-29 00:21:46 UTC
Created attachment 258371 [details] [review]
build: update makefiles to build using C++
Comment 22 darkxst 2013-10-29 00:21:51 UTC
Created attachment 258372 [details] [review]
fix declaration of JSClasses to be valid c++ syntax
Comment 23 darkxst 2013-10-29 00:21:57 UTC
Created attachment 258373 [details] [review]
update to c++ types and api for JSHandle* Objects
Comment 24 darkxst 2013-10-29 00:22:04 UTC
Created attachment 258374 [details] [review]
update to c++ api for fop->runtime()
Comment 25 darkxst 2013-10-29 00:22:10 UTC
Created attachment 258375 [details] [review]
param.cpp fix jump over value initialisation
Comment 26 darkxst 2013-10-29 00:22:16 UTC
Created attachment 258376 [details] [review]
fix invalid syntax on proto_props resulting in unknown size errors
Comment 27 darkxst 2013-10-29 00:22:21 UTC
Created attachment 258377 [details] [review]
build: fix implicit pointer conversion errors
Comment 28 darkxst 2013-10-29 00:25:49 UTC
yes bad rebase, moved into the correct patch now (the JSHandles* one)
Comment 29 Jasper St. Pierre (not reading bugmail) 2013-10-29 01:39:53 UTC
looks fine, go ahead and push
Comment 30 darkxst 2013-10-29 02:46:55 UTC
Attachment 258370 [details] pushed as 361f0b9 - build: rename all c file to cpp
Attachment 258371 [details] pushed as 7a88ac3 - build: update makefiles to build using C++
Attachment 258372 [details] pushed as e70b125 - fix declaration of JSClasses to be valid c++ syntax
Attachment 258373 [details] pushed as 9daff9c - update to c++ types and api for JSHandle* Objects
Attachment 258374 [details] pushed as d84c53a - update to c++ api for fop->runtime()
Attachment 258375 [details] pushed as 5c110be - param.cpp fix jump over value initialisation
Attachment 258376 [details] pushed as 13150fe - fix invalid syntax on proto_props resulting in unknown size errors
Attachment 258377 [details] pushed as 4d55582 - build: fix implicit pointer conversion errors