After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710875 - prerequisite cpp patches
prerequisite cpp patches
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-25 12:39 UTC by darkxst
Modified: 2013-10-25 13:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix Wsign-compare warnings (954 bytes, patch)
2013-10-25 12:40 UTC, darkxst
committed Details | Review
don't use reserved c++ keywords class, namespace and throw (22.79 KB, patch)
2013-10-25 12:40 UTC, darkxst
committed Details | Review

Description darkxst 2013-10-25 12:39:28 UTC
A couple of prerequisite patches for porting gjs to cpp/js24
Comment 1 darkxst 2013-10-25 12:40:30 UTC
Created attachment 258112 [details] [review]
fix Wsign-compare warnings
Comment 2 darkxst 2013-10-25 12:40:34 UTC
Created attachment 258113 [details] [review]
don't use reserved c++ keywords class, namespace and throw
Comment 3 Colin Walters 2013-10-25 13:19:18 UTC
Review of attachment 258112 [details] [review]:

Just one totally minor comment, please commit after.

::: gjs/mem.c
@@ +75,3 @@
     int i;
     int n_counters;
+    unsigned int total_objects;

I prefer "guint" just since it's less typing.
Comment 4 Colin Walters 2013-10-25 13:22:34 UTC
Review of attachment 258113 [details] [review]:

Looks good!  Thank you so much for diving into this!
Comment 5 darkxst 2013-10-25 13:26:57 UTC
Attachment 258112 [details] pushed as efb514d - fix Wsign-compare warnings
Attachment 258113 [details] pushed as 9a48816 - don't use reserved c++ keywords class, namespace and throw