GNOME Bugzilla – Bug 710875
prerequisite cpp patches
Last modified: 2013-10-25 13:27:03 UTC
A couple of prerequisite patches for porting gjs to cpp/js24
Created attachment 258112 [details] [review] fix Wsign-compare warnings
Created attachment 258113 [details] [review] don't use reserved c++ keywords class, namespace and throw
Review of attachment 258112 [details] [review]: Just one totally minor comment, please commit after. ::: gjs/mem.c @@ +75,3 @@ int i; int n_counters; + unsigned int total_objects; I prefer "guint" just since it's less typing.
Review of attachment 258113 [details] [review]: Looks good! Thank you so much for diving into this!
Attachment 258112 [details] pushed as efb514d - fix Wsign-compare warnings Attachment 258113 [details] pushed as 9a48816 - don't use reserved c++ keywords class, namespace and throw