GNOME Bugzilla – Bug 710852
evolution-alarm-notify fails to link due to e_mail_part_list_is_empty
Last modified: 2014-03-13 17:29:12 UTC
Created attachment 258078 [details] [review] Add em-format/libevolution-mail-formatter.la to evolution_alarm_notify_LDADD While building evolution 3.10.1 in Gentoo, evolution-alarm-notify fails to link since libevolution-mail-composer.la is in evolution_alarm_notify_LDADD, but em-format/libevolution-mail-formatter.la is not. By adding em-format/libevolution-mail-formatter.la to evolution_alarm_notify_LDADD, I'm able to compile it, but I'm not sure it's the right solution.
The build fails with this message: /bin/sh ../../libtool --tag=CC --mode=link x86_64-pc-linux-gnu-gcc -march=core2 -O2 -pipe -fno-strict-aliasing -Wl,-O1 -Wl,--as-needed -Wl,--no-undefined -o evolution-alarm-notify evolution_alarm_notify-alarm.o evolution_alarm_notify-alarm-notify.o evolution_alarm_notify-alarm-notify-dialog.o evolution_alarm_notify-alarm-queue.o evolution_alarm_notify-config-data.o evolution_alarm_notify-notify-main.o evolution_alarm_notify-util.o ../../e-util/libevolution-util.la ../../composer/libevolution-mail-composer.la ../../calendar/gui/libevolution-calendar.la ../../calendar/importers/libevolution-calendar-importers.la ../../addressbook/gui/contact-editor/libecontacteditor.la ../../addressbook/gui/contact-list-editor/libecontactlisteditor.la ../../addressbook/util/libeabutil.la -lebook-1.2 -ledata-book-1.2 -lebook-contacts-1.2 -lecal-1.2 -lical -licalss -licalvcal -lpthread -lebackend-1.2 -ledataserver-1.2 -Wl,--export-dynamic -lgmodule-2.0 -pthread -lrt -lcamel-1.2 -lsqlite3 -lssl3 -lsmime3 -lnss3 -lnssutil3 -lplds4 -lplc4 -lnspr4 -lsecret-1 -lxml2 -lsoup-2.4 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -Wl,--export-dynamic -lgmodule-2.0 -pthread -lrt -lgailutil-3 -lxml2 -lgnome-desktop-3 -lwebkitgtk-3.0 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lsoup-2.4 -lgio-2.0 -lgobject-2.0 -ljavascriptcoregtk-3.0 -lglib-2.0 -lnotify -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lcanberra-gtk3 -lX11 -lcanberra -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lgtkhtml-editor-4.0 -lgtkhtml-4.0 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lenchant -lgmodule-2.0 -pthread -lrt -lglib-2.0 -lcairo libtool: link: x86_64-pc-linux-gnu-gcc -march=core2 -O2 -pipe -fno-strict-aliasing -Wl,-O1 -Wl,--no-undefined -o .libs/evolution-alarm-notify evolution_alarm_notify-alarm.o evolution_alarm_notify-alarm-notify.o evolution_alarm_notify-alarm-notify-dialog.o evolution_alarm_notify-alarm-queue.o evolution_alarm_notify-config-data.o evolution_alarm_notify-notify-main.o evolution_alarm_notify-util.o -Wl,--export-dynamic -pthread -Wl,--export-dynamic -pthread -pthread -Wl,--as-needed ../../e-util/.libs/libevolution-util.so ../../composer/.libs/libevolution-mail-composer.so ../../calendar/gui/.libs/libevolution-calendar.so ../../calendar/importers/.libs/libevolution-calendar-importers.so ../../addressbook/gui/contact-editor/.libs/libecontacteditor.so ../../addressbook/gui/contact-list-editor/.libs/libecontactlisteditor.so ../../addressbook/util/.libs/libeabutil.so -lebook-1.2 -ledata-book-1.2 -lebook-contacts-1.2 -lecal-1.2 -lical -licalss -licalvcal -lpthread -lebackend-1.2 -ledataserver-1.2 -lcamel-1.2 -lsqlite3 -lssl3 -lsmime3 -lnss3 -lnssutil3 -lplds4 -lplc4 -lnspr4 -lsecret-1 -lgailutil-3 -lxml2 -lgnome-desktop-3 -lwebkitgtk-3.0 -lsoup-2.4 -ljavascriptcoregtk-3.0 -lnotify -lcanberra-gtk3 -lX11 -lcanberra -lgtkhtml-editor-4.0 -lgtkhtml-4.0 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lenchant -lgmodule-2.0 -lrt -lglib-2.0 -lcairo -pthread -Wl,-rpath -Wl,/usr/lib64/evolution/3.10 ../../composer/.libs/libevolution-mail-composer.so: undefined reference to `e_mail_part_list_is_empty' collect2: error: ld returned 1 exit status
Strange, I can't reproduce the build failure even with binutils-gold, which usually catches this sort of thing. Nevertheless, your patch looks correct. Fixed for Evolution 3.11.2 and 3.10.2: https://git.gnome.org/browse/evolution/commit/?id=98500a2729f6045809f657da2d4f2bc7191a72fb https://git.gnome.org/browse/evolution/commit/?h=gnome-3-10&id=0a835f1dfde7f52b516f44310b7b81c39a07af89 Thanks!
(In reply to comment #2) > Strange, I can't reproduce the build failure even with binutils-gold, which > usually catches this sort of thing. Nevertheless, your patch looks correct. I'm using gcc 4.8.1 and binutils 2.23.1, if it helps. Also, by default Gentoo links with -Wl,--as-needed; I don't know if that's related. > Fixed for Evolution 3.11.2 and 3.10.2: > > https://git.gnome.org/browse/evolution/commit/?id=98500a2729f6045809f657da2d4f2bc7191a72fb > > https://git.gnome.org/browse/evolution/commit/?h=gnome-3-10&id=0a835f1dfde7f52b516f44310b7b81c39a07af89 > > Thanks! Thanks to you.
*** Bug 710498 has been marked as a duplicate of this bug. ***