After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710821 - Assorted cleanups
Assorted cleanups
Status: RESOLVED OBSOLETE
Product: cheese
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-10-24 16:52 UTC by Bastien Nocera
Modified: 2020-11-12 07:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
libcheese: Remove gdk_threads* calls (4.77 KB, patch)
2013-10-24 16:53 UTC, Bastien Nocera
committed Details | Review
libcheese: Update TotemAspectFrame from totem (9.53 KB, patch)
2013-10-24 16:53 UTC, Bastien Nocera
committed Details | Review
libcheese: Use a layout manager instead of constraints (1.51 KB, patch)
2013-10-24 16:53 UTC, Bastien Nocera
committed Details | Review
libcheese: Use gnome-shell to trigger the flash (8.93 KB, patch)
2013-10-24 16:53 UTC, Bastien Nocera
reviewed Details | Review

Description Bastien Nocera 2013-10-24 16:52:54 UTC
.
Comment 1 Bastien Nocera 2013-10-24 16:53:12 UTC
Created attachment 258039 [details] [review]
libcheese: Remove gdk_threads* calls

And bump the GTK+ required version to 3.6.
Comment 2 Bastien Nocera 2013-10-24 16:53:17 UTC
Created attachment 258040 [details] [review]
libcheese: Update TotemAspectFrame from totem
Comment 3 Bastien Nocera 2013-10-24 16:53:22 UTC
Created attachment 258041 [details] [review]
libcheese: Use a layout manager instead of constraints

This reduces property changes for every little change in the stage's
properties.
Comment 4 Bastien Nocera 2013-10-24 16:53:27 UTC
Created attachment 258042 [details] [review]
libcheese: Use gnome-shell to trigger the flash

This fixes problems with the parent window losing focus when
the flash is triggered.
Comment 5 David King 2013-10-25 09:24:41 UTC
Review of attachment 258039 [details] [review]:

Looks fine, please push.
Comment 6 David King 2013-10-25 09:25:17 UTC
Review of attachment 258040 [details] [review]:

Looks fine, please push.
Comment 7 David King 2013-10-25 09:26:14 UTC
Review of attachment 258041 [details] [review]:

Looks good to me, please push.
Comment 8 David King 2013-10-25 09:41:45 UTC
Review of attachment 258042 [details] [review]:

The change to use the D-Bus interface seems fine, but changing CheeseFlash to be a GObject rather than a GtkWindow leads to an ABI change, right? If so, it would be good to look for some other ABI-breaking candidates and to do those at the same time.
Comment 9 David King 2013-10-28 20:54:36 UTC
Comment on attachment 258039 [details] [review]
libcheese: Remove gdk_threads* calls

Pushed a slightly-modifed commit to master as 54e04d97b5f96c0012b9bc3e2e0b25afe5243c88.
Comment 10 David King 2013-10-28 20:54:59 UTC
Comment on attachment 258040 [details] [review]
libcheese: Update TotemAspectFrame from totem

Pushed to master as commit ba8078d42c871535a0e45e46a571e0d743d1e04e.
Comment 11 David King 2013-10-28 20:55:59 UTC
Comment on attachment 258041 [details] [review]
libcheese: Use a layout manager instead of constraints

Pushed to master as commit 341fcb6d2f1e0726eda5a7f84e033af47703d3e9.
Comment 12 Jasper St. Pierre (not reading bugmail) 2013-10-28 21:36:56 UTC
(In reply to comment #4)
> Created an attachment (id=258042) [details] [review]
> libcheese: Use gnome-shell to trigger the flash

I'm not comfortable with this. Apps should not depend on gnome-shell to work properly.
Comment 13 David King 2013-10-28 21:40:33 UTC
Seems a fair point that applications should not depend on the shell. If there are any follow-up comments about the flash patch, let's deal with them in a separate bug.
Comment 14 Bastien Nocera 2013-10-28 22:04:19 UTC
(In reply to comment #12)
> (In reply to comment #4)
> > Created an attachment (id=258042) [details] [review] [details] [review]
> > libcheese: Use gnome-shell to trigger the flash
> 
> I'm not comfortable with this. Apps should not depend on gnome-shell to work
> properly.

Totem and gnome-settings-daemon (at least) use this when capturing screenshots.

(In reply to comment #13)
> Seems a fair point that applications should not depend on the shell. If there
> are any follow-up comments about the flash patch, let's deal with them in a
> separate bug.

The flash is utterly broken. Try the test app.
Comment 15 Jasper St. Pierre (not reading bugmail) 2013-10-28 22:05:42 UTC
gnome-settings-daemon is not an app. I'm fine with low-level system plumbing using it.

Totem certainly should not be using it. Fix cheese-flash.c instead of using shell-specific interfaces.
Comment 16 Bastien Nocera 2013-10-28 22:57:55 UTC
(In reply to comment #15)
> gnome-settings-daemon is not an app. I'm fine with low-level system plumbing
> using it.
> 
> Totem certainly should not be using it. Fix cheese-flash.c instead of using
> shell-specific interfaces.

A GNOME app using GNOME shell features...
Comment 17 André Klapper 2020-11-12 07:12:02 UTC
bugzilla.gnome.org is being replaced by gitlab.gnome.org. We are closing all
old bug reports and feature requests in GNOME Bugzilla which have not seen
updates for a long time.

If you still use cheese and if you still see this bug / want this feature in a
recent and currently supported version, then please feel free to report it at
https://gitlab.gnome.org/GNOME/cheese/-/issues/

Thank you for creating this report and we are sorry it could not be implemented
(volunteer workforce and time is quite limited).