GNOME Bugzilla – Bug 710821
Assorted cleanups
Last modified: 2020-11-12 07:12:02 UTC
.
Created attachment 258039 [details] [review] libcheese: Remove gdk_threads* calls And bump the GTK+ required version to 3.6.
Created attachment 258040 [details] [review] libcheese: Update TotemAspectFrame from totem
Created attachment 258041 [details] [review] libcheese: Use a layout manager instead of constraints This reduces property changes for every little change in the stage's properties.
Created attachment 258042 [details] [review] libcheese: Use gnome-shell to trigger the flash This fixes problems with the parent window losing focus when the flash is triggered.
Review of attachment 258039 [details] [review]: Looks fine, please push.
Review of attachment 258040 [details] [review]: Looks fine, please push.
Review of attachment 258041 [details] [review]: Looks good to me, please push.
Review of attachment 258042 [details] [review]: The change to use the D-Bus interface seems fine, but changing CheeseFlash to be a GObject rather than a GtkWindow leads to an ABI change, right? If so, it would be good to look for some other ABI-breaking candidates and to do those at the same time.
Comment on attachment 258039 [details] [review] libcheese: Remove gdk_threads* calls Pushed a slightly-modifed commit to master as 54e04d97b5f96c0012b9bc3e2e0b25afe5243c88.
Comment on attachment 258040 [details] [review] libcheese: Update TotemAspectFrame from totem Pushed to master as commit ba8078d42c871535a0e45e46a571e0d743d1e04e.
Comment on attachment 258041 [details] [review] libcheese: Use a layout manager instead of constraints Pushed to master as commit 341fcb6d2f1e0726eda5a7f84e033af47703d3e9.
(In reply to comment #4) > Created an attachment (id=258042) [details] [review] > libcheese: Use gnome-shell to trigger the flash I'm not comfortable with this. Apps should not depend on gnome-shell to work properly.
Seems a fair point that applications should not depend on the shell. If there are any follow-up comments about the flash patch, let's deal with them in a separate bug.
(In reply to comment #12) > (In reply to comment #4) > > Created an attachment (id=258042) [details] [review] [details] [review] > > libcheese: Use gnome-shell to trigger the flash > > I'm not comfortable with this. Apps should not depend on gnome-shell to work > properly. Totem and gnome-settings-daemon (at least) use this when capturing screenshots. (In reply to comment #13) > Seems a fair point that applications should not depend on the shell. If there > are any follow-up comments about the flash patch, let's deal with them in a > separate bug. The flash is utterly broken. Try the test app.
gnome-settings-daemon is not an app. I'm fine with low-level system plumbing using it. Totem certainly should not be using it. Fix cheese-flash.c instead of using shell-specific interfaces.
(In reply to comment #15) > gnome-settings-daemon is not an app. I'm fine with low-level system plumbing > using it. > > Totem certainly should not be using it. Fix cheese-flash.c instead of using > shell-specific interfaces. A GNOME app using GNOME shell features...
bugzilla.gnome.org is being replaced by gitlab.gnome.org. We are closing all old bug reports and feature requests in GNOME Bugzilla which have not seen updates for a long time. If you still use cheese and if you still see this bug / want this feature in a recent and currently supported version, then please feel free to report it at https://gitlab.gnome.org/GNOME/cheese/-/issues/ Thank you for creating this report and we are sorry it could not be implemented (volunteer workforce and time is quite limited).