After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710811 - missed message from notification
missed message from notification
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-24 14:35 UTC by William Jon McCann
Modified: 2017-08-23 22:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
chatView: Activate the correct room when clicking a notification (1.91 KB, patch)
2013-10-25 10:19 UTC, Florian Müllner 		committed Details | Review

Description William Jon McCann 2013-10-24 14:35:47 UTC 
I got a notification that I was mentioned in a room. I clicked the notification. I was switched to Polari but there was no mention of me in the room that was selected and no number badges in the room list. I had to look through all the rooms to look for the message.

Ideally we would switch to the room where the mention was. In any case we should show a badge next to the room to indicate where to go - and not remove it until it was actually seen.
Comment 1 Florian Müllner 2013-10-24 14:39:26 UTC 
Bug 710585 has a (needs-work) patch for this using the new GNotification API ...
Comment 2 Florian Müllner 2013-10-25 10:19:06 UTC 
Created attachment 258091 [details] [review]
chatView: Activate the correct room when clicking a notification

Clicking a notification should not only activate Polari, but also
switch to the room where the mention was made. Implement this
using an appropriate default action.


Porting to GNotification will break compatibility with F20, so I'm not in a big hurry of merging it - let's implement this using the old API for now.
Comment 3 Florian Müllner 2013-10-25 10:19:57 UTC 
Comment on attachment 258091 [details] [review]
chatView: Activate the correct room when clicking a notification

Attachment 258091 [details] pushed as 7733408 - chatView: Activate the correct room when clicking a notification

Leaving open for the badge issue ...
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-10-27 05:18:35 UTC 
(In reply to comment #1)
> Bug 710585 has a (needs-work) patch for this using the new GNotification API
> ...

It's not marked needs-work for me. Maybe you forgot to hit publish?
Comment 5 Alexandre Franke 2016-07-28 13:41:53 UTC 
It looks like this issue can be closed as FIXED. Or am I missing something?
Comment 6 Daniel Boles 2017-08-23 22:36:38 UTC 
Yup, a badge is shown just fine these days.