After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710765 - Add names to all the timeouts
Add names to all the timeouts
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on: 712284
Blocks:
 
 
Reported: 2013-10-23 22:33 UTC by Bastien Nocera
Modified: 2013-12-18 14:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add names to all the timeouts (7.48 KB, patch)
2013-10-23 22:33 UTC, Bastien Nocera
accepted-commit_now Details | Review
Add names to all the timeouts (7.49 KB, patch)
2013-12-13 14:41 UTC, Bastien Nocera
committed Details | Review

Comment 1 Bastien Nocera 2013-10-23 22:33:57 UTC
Created attachment 257979 [details] [review]
Add names to all the timeouts
Comment 2 Claudio Saavedra 2013-10-28 15:21:35 UTC
Review of attachment 257979 [details] [review]:

I might end up proving my stupidity by asking this, but isn't it possible to achieve this by some sort __PRETTY_FUNCTION__ combination with g_get_prgname(), inside of g_source_add() or equivalent?
Comment 3 Bastien Nocera 2013-10-28 15:31:02 UTC
If you want all the timeouts to say "g_source_add" as the function name, sure.
Comment 4 Claudio Saavedra 2013-10-28 19:01:37 UTC
You know I didn't mean that :)
Comment 5 Claudio Saavedra 2013-11-14 10:50:38 UTC
Review of attachment 257979 [details] [review]:

Until we have a better way to do this, I guess we can commit. I still think that a macro for adding named sources would be handy here, but whatever…
Comment 7 Claudio Saavedra 2013-11-14 11:10:21 UTC
Right. In that case maybe we can wait for this to land in glib. Do you know whether there are plans for it?
Comment 8 Bastien Nocera 2013-11-14 11:13:35 UTC
I don't have any plans for it, and I don't know that there are (I don't know of any bugs filed).
Comment 9 Claudio Saavedra 2013-11-14 11:18:31 UTC
Okay, just filed it.
Comment 10 Bastien Nocera 2013-12-13 14:41:12 UTC
Created attachment 264153 [details] [review]
Add names to all the timeouts
Comment 11 Bastien Nocera 2013-12-18 14:48:24 UTC
Committed to master, as discussed on IRC a couple of days ago.

Attachment 264153 [details] pushed as a09a8f0 - Add names to all the timeouts