After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710745 - Shell crashes when switching windows on an empty workspace
Shell crashes when switching windows on an empty workspace
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: app-switcher
3.10.x
Other Linux
: Normal major
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 723046 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-10-23 18:51 UTC by Clément Guérin
Modified: 2014-04-26 21:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Stack trace (5.81 KB, text/plain)
2013-10-23 18:52 UTC, Clément Guérin
  Details
add a test to avoid creating switcher when we have no items (762 bytes, patch)
2013-10-24 17:04 UTC, sébastien lafargue
none Details | Review
add tests to avoid creating switcher when we have no items (1.01 KB, patch)
2013-10-24 18:11 UTC, sébastien lafargue
needs-work Details | Review
same patch with style correction (974 bytes, patch)
2013-10-25 17:10 UTC, sébastien lafargue
committed Details | Review

Description Clément Guérin 2013-10-23 18:51:33 UTC
Steps to reproduce :
1) Change org.gnome.shell.app-switcher.current-workspace-only to true
2) Leave the terminal open, and switch to an empty workspace
3) Alt+tab or Super+tab makes the shell crash instantly

Stack trace is attached, one interesting line :
> (gnome-shell:1870): Clutter-ERROR **: ClutterBoxLayout child ShellGenericContainer minimum width: -8,000000 < 0 for height 40
Comment 1 Clément Guérin 2013-10-23 18:52:06 UTC
Created attachment 257955 [details]
Stack trace
Comment 2 sébastien lafargue 2013-10-24 17:04:06 UTC
Created attachment 258044 [details] [review]
add a test to avoid creating switcher when we have no items
Comment 3 sébastien lafargue 2013-10-24 18:11:55 UTC
Created attachment 258045 [details] [review]
add tests to avoid creating switcher when we have no items

sorry it was half the solution, but i still have all windows in windows switcher with curent-workspace-only, and you ?
Comment 4 Clément Guérin 2013-10-25 15:47:30 UTC
The patch fixes the problem, awesome! Can't wait for a new point release integrating the fix.

I think you have to change :
org.gnome.shell.window-switcher.current-workspace-only

instead of :
org.gnome.shell.app-switcher.current-workspace-only
Comment 5 Clément Guérin 2013-10-25 16:35:27 UTC
Review of attachment 258045 [details] [review]:

Fixes the problem, entirely functionnal.

Would be nice to add an empty line between the two returns like this

>     return false;
> +
> return true;
Comment 6 sébastien lafargue 2013-10-25 17:10:18 UTC
Created attachment 258139 [details] [review]
same patch with style correction
Comment 7 Giovanni Campagna 2013-10-26 14:30:46 UTC
Reviewed and then pushed immediately with a better commit message.
Comment 8 Clément Guérin 2013-11-14 11:32:14 UTC
Looks like this patch hasn't been merged into gnome-3.10 branch. :(
Comment 9 Clément Guérin 2013-11-15 22:00:47 UTC
It didn't made it to gnome-shell 3.10.2... Please fix it!
Comment 10 Florian Müllner 2014-04-26 21:12:17 UTC
*** Bug 723046 has been marked as a duplicate of this bug. ***