After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710678 - gvfsd-http assert failure in g_error_free()
gvfsd-http assert failure in g_error_free()
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: http backend
1.18.x
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-22 20:11 UTC by Sebastien Bacher
Modified: 2013-10-25 07:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
http: Set error to NULL to prevent crash on close (755 bytes, patch)
2013-10-23 06:14 UTC, Ross Lagerwall 		accepted-commit_now Details | Review

Description Sebastien Bacher 2013-10-22 20:11:55 UTC 
The bug has been reported on https://bugs.launchpad.net/ubuntu/+source/gvfs/+bug/1210852

"#0  0x00007f6a20481f77 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
        resultvar = 0
        pid = 3788
        selftid = 3788

+ Trace 232659

  • #1 __GI_abort
    at abort.c line 90
  • #2 __libc_message
    at ../sysdeps/unix/sysv/linux/libc_fatal.c line 199
  • #3 malloc_printerr
  • #4 g_error_free
    at /build/buildd/glib2.0-2.37.3/./glib/gerror.c line 476
  • #5 close_read_ready
    at gvfsbackendhttp.c line 528
  • #6 g_task_return_now
    at /build/buildd/glib2.0-2.37.3/./gio/gtask.c line 1108
  • #7 complete_in_idle_cb
    at /build/buildd/glib2.0-2.37.3/./gio/gtask.c line 1117
  • #8 g_main_dispatch
    at /build/buildd/glib2.0-2.37.3/./glib/gmain.c line 3058
  • #9 g_main_context_dispatch
    at /build/buildd/glib2.0-2.37.3/./glib/gmain.c line 3634 






Comment 1


Sebastien Bacher





          2013-10-22 20:15:00 UTC
        



similar bug in fedora reports: http://retrace.fedoraproject.org/faf/reports/108229/






Comment 2


Ross Lagerwall





          2013-10-23 06:14:24 UTC
        



Created attachment 257890 [details] [review]
http: Set error to NULL to prevent crash on close






Comment 3


Ondrej Holy





          2013-10-24 13:06:08 UTC
        



Review of attachment 257890 [details] [review]:

Not sure the patch fix this bug, however at least doesn't break anything and it is good practice...






Comment 4


Ross Lagerwall





          2013-10-24 13:35:43 UTC
        



(In reply to comment #3)
> Review of attachment 257890 [details] [review]:
> 
> Not sure the patch fix this bug, however at least doesn't break anything and it
> is good practice...

Yeah, but since the traceback indicates "invalid pointer" at malloc.c called via g_error_free(), it seems possible that we're trying to free an invalid pointer *because* error was not set to NULL.






Comment 5


Ross Lagerwall





          2013-10-25 07:49:14 UTC
        



Pushed to master as 084a365 and stable as de8ad26.

I'm going to close this for now.  We can reopen it if there are further problems.