After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710661 - Adblock prevent softpedia.com to load images
Adblock prevent softpedia.com to load images
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
3.10.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-22 15:59 UTC by Eddy Castillo
Modified: 2013-10-30 11:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update EasyList filter rules URL for ad blocker (1.16 KB, patch)
2013-10-27 14:43 UTC, Adrian Perez
committed Details | Review

Description Eddy Castillo 2013-10-22 15:59:36 UTC
Adblock is blocking all images in softpedia.com making the website look bad. Loading the same page with Firefox and Chrome with adblock activated show the page correctly. This brings another issue, there is no way to whitelist a website.
Comment 1 Eddy Castillo 2013-10-25 17:33:26 UTC
Update, also http://imgur.com/ it's affected by this. Which is inconvenient given that imgur is an image hosting site.
Comment 2 Adrian Perez 2013-10-27 14:37:06 UTC
I have been also experiencing this. It seems to be related to the URL
from where the EasyList rules are being loaded. The URL being use by
Epiphany is (embed/uri-tester.c, line 33):

 #define FILTER_DEFAULT_URL "http://adblockplus.mozdev.org/easylist/easylist.txt"

whereas in https://adblockplus.org/en/subscriptions the supplied URL
is different:

 https://easylist-downloads.adblockplus.org/easylist.txt&title=EasyList

Right now the first URL is actually a redirect to the second one:

 % curl -I http://adblockplus.mozdev.org/easylist/easylist.txt
 HTTP/1.1 302 Moved Temporarily
 Server: nginx/1.0.6
 Date: Sun, 27 Oct 2013 14:28:18 GMT
 Content-Type: text/html
 Content-Length: 160
 Connection: keep-alive
 Location: https://easylist-downloads.adblockplus.org/easylist.txt

Checking the contents of the filter list present in the profile dir
(~/.config/epiphany/adblock/1ef36f48cb2d8e8033a55d0fe396973d) it
turns out that the contents are different from the ones pointed by
the second URL. A possible reason for being stuck with old rules:
likely, the old URL was not a redirect some time ago, and the fact
that it changed to a redirect is not being somehow well handled.

As a workaround, the following will work (make sure to enter the
commands with no Epiphany processes running):

 % rm ~/.config/epiphany/adblock/*
 % echo -n 'https://easylist-downloads.adblockplus.org/easylist.txt;' \
    > ~/.config/epiphany/adblock/filters.list

Now run Epiphany, and it will download the rules from the location.

IMHO it should be better if the URL in the Epiphany code was updated
to point to the new location. Maybe it is also worth to investigate
a bit whether redirects in blocklist URLs are properly handled (or,
if that's not the reason, determine which some people like us ended
up with stale filter rules files).
Comment 3 Adrian Perez 2013-10-27 14:43:19 UTC
Created attachment 258219 [details] [review]
Update EasyList filter rules URL for ad blocker

Tentative patch.
Comment 4 Eddy Castillo 2013-10-27 20:11:39 UTC
That didn't fix it for me, but thanks for pointing me out to adblock files. I found that imgur page is loading fine after commenting/deleting rule:

||imgur.com^$image,domain=talksport.com

I don't know why, but it seems to work. I couldn't do the same with softpedia.com though, even adding it to whitelist didn't work.

@@||http://softpedia.com

As https://adblockplus.org/en/filters#whitelist says.
Comment 5 Claudio Saavedra 2013-10-28 15:14:03 UTC
Review of attachment 258219 [details] [review]:

Even if this doesn't entirely fixes the bug, I think we should push this.
Comment 6 Claudio Saavedra 2013-10-28 15:15:23 UTC
Review of attachment 258219 [details] [review]:

Maybe update the comment taking into account latest comments.
Comment 7 Claudio Saavedra 2013-10-30 11:14:55 UTC
Attachment 258219 [details] pushed as 4d7c9cb - Update EasyList filter rules URL for ad blocker