After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710649 - Missed translation marks for some strings in gschema files
Missed translation marks for some strings in gschema files
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-22 13:27 UTC by juliette.tux
Modified: 2017-05-24 15:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
data: Mark forgotten strings in gschema files for translation (16.39 KB, patch)
2017-05-24 15:46 UTC, Piotr Drąg
committed Details | Review

Description juliette.tux 2013-10-22 13:27:59 UTC
Hello from Russian GNOME localization team,
We've found some strings in 
gnome-tweak-tool/gtweak/tweakmodel.py which should be marked for translation but they're not, and thus they are missed in .pot and are shown in English only in the GUI. For example the string:
GSettingsComboEnumTweak("org.gnome.settings-daemon.plugins.power", "button-power", size_group=sg)
with corresponding option in https://git.gnome.org/browse/gnome-settings-daemon/tree/data/org.gnome.settings-daemon.plugins.power.gschema.xml.in.in?h=gnome-3-8#n59  which gives us "Power button action" string missed in .po.

Could somebody please check the gnome-tweak-tool source tree for all such missing translation strings and fix the .pot? We can still make it to the 3.10 release.
Thank you.
Comment 1 Piotr Drąg 2015-04-08 13:48:43 UTC
This looks like a bug in gnome-settings-daemon, in which not all strings in gschema files are marked for translation.
Comment 2 Piotr Drąg 2017-05-24 15:46:28 UTC
Created attachment 352511 [details] [review]
data: Mark forgotten strings in gschema files for translation

This patch fixes the bug.
Comment 3 Rui Matos 2017-05-24 15:49:09 UTC
Review of attachment 352511 [details] [review]:

thanks! please push to master
Comment 4 Piotr Drąg 2017-05-24 15:51:41 UTC
Comment on attachment 352511 [details] [review]
data: Mark forgotten strings in gschema files for translation

Thank you!

https://git.gnome.org/browse/gnome-settings-daemon/commit/?id=46d36d93d0eb2bf68855e8890b0272b77bd2b4b4