After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710643 - DBusObjectManagerClient.new[_for_bus]() missing ‘throws’
DBusObjectManagerClient.new[_for_bus]() missing ‘throws’
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings: GLib
0.22.x
Other All
: Normal major
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks: 685848
 
 
Reported: 2013-10-22 12:13 UTC by Philip Withnall
Modified: 2013-10-24 15:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gio-2.0: Add ‘throws’ to DBusObjectManagerClient.new[_for_bus]() (3.19 KB, patch)
2013-10-22 12:14 UTC, Philip Withnall 		needs-work Details | Review
gio-2.0: Add ‘throws’ to DBusObjectManagerClient.new[_for_bus]() (4.86 KB, patch)
2013-10-23 07:07 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2013-10-22 12:13:08 UTC 
DBusObjectManagerClietn.new[for_bus]() take a GError parameter in their _finish() functions, but the .vapi doesn’t show this.

Patch coming.
Comment 1 Philip Withnall 2013-10-22 12:14:05 UTC 
Created attachment 257846 [details] [review]
gio-2.0: Add ‘throws’ to DBusObjectManagerClient.new[_for_bus]()
Comment 2 Evan Nemerson 2013-10-23 01:30:04 UTC 
Those are defined in vapi/metadata/Gio-2.0-custom.vala.  Could you fix them there instead of in the metadata?
Comment 3 Philip Withnall 2013-10-23 07:07:10 UTC 
Created attachment 257893 [details] [review]
gio-2.0: Add ‘throws’ to DBusObjectManagerClient.new[_for_bus]()
Comment 4 Philip Withnall 2013-10-23 08:22:24 UTC 
Comment on attachment 257893 [details] [review]
gio-2.0: Add ‘throws’ to DBusObjectManagerClient.new[_for_bus]()

commit 2c8c55a46a001ddb3ea7dcb2a2af379da40446b6
Author: Philip Withnall <philip.withnall@collabora.co.uk>
Date:   Tue Oct 22 13:13:36 2013 +0100

    gio-2.0: Add ‘throws’ to DBusObjectManagerClient.new[_for_bus]()
    
    https://bugzilla.gnome.org/show_bug.cgi?id=710643

 vapi/gio-2.0.vapi                 | 4 ++--
 vapi/metadata/Gio-2.0-custom.vala | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)