GNOME Bugzilla – Bug 710630
Remove internal version of dbus-glib functions
Last modified: 2021-07-05 10:45:52 UTC
.
Created attachment 257839 [details] [review] Remove internal version of dbus-glib functions This code is complicated enough that we really don't need it in 2 different places. Use the version in dbus-glib instead.
Created attachment 257844 [details] [review] Don't use at-spi2-core copy of dbus-glib function
I tested that the patches works, and also reviewed them. They are really straightforward. Having said so, I also made some research of why those functions were added. On 2010 at-spi2-core already had a dependency with dbus-glib, and where using those functions directly. Then Andre created a bug to remove that dependency in favor of gdbus: https://www.libreoffice.org/bugzilla/show_bug.cgi?id=28778 The problem is that gdbus didn't have an equivalent to those two dbus-glib functions. Mike opened a bug to include those two methods, initially on dbus directly: https://bugs.freedesktop.org/show_bug.cgi?id=31515 But that option was discarded, and a discussion started about where to place it (dbus, libegg, etc). While the bug was not resolved (the discussion was slow, splitted through the years), Mike just C&P those two methods, and removed the dbus-glib dependency as asked. Additionally, that bug was closed as WONTFIX, and with a comment that seemed to give up with some modules: "Most GLib apps have already moved; it's mostly only the difficult cases (NetworkManager, Telepathy) that are still using dbus-glib." Anyway, will just add a comment on that free desktop bug.
The other issue is that there was a crash caused by what I believe to be an inappropriate assert, and I basically forgot about it without ever having received permission to commit the patch into dbus-glib. See https://bugs.freedesktop.org/show_bug.cgi?id=30574#c8 I just added another comment on the bug to see if I can get a review.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/at-spi2-core/-/issues/ Thank you for your understanding and your help.