After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710622 - window: Use new GtkSearchEntry feature
window: Use new GtkSearchEntry feature
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: devhelp-maint
devhelp-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-22 10:23 UTC by Bastien Nocera
Modified: 2013-10-22 22:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window: Use new GtkSearchEntry feature (2.05 KB, patch)
2013-10-22 10:23 UTC, Bastien Nocera 		accepted-commit_now Details | Review
window: Use new GtkSearchEntry feature (2.43 KB, patch)
2013-10-22 22:12 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2013-10-22 10:23:13 UTC 
.
Comment 1 Bastien Nocera 2013-10-22 10:23:21 UTC 
Created attachment 257833 [details] [review]
window: Use new GtkSearchEntry feature

Instead of using a timeout ourselves, listen on the search-changed
signal, which emits after 300 msecs.
Comment 2 Aleksander Morgado 2013-10-22 11:31:29 UTC 
Review of attachment 257833 [details] [review]:

Do we also need a GTK+ version bump in configure.ac? Currently we expect at least 3.9.8.
Comment 3 Bastien Nocera 2013-10-22 22:12:46 UTC 
Created attachment 257883 [details] [review]
window: Use new GtkSearchEntry feature

Instead of using a timeout ourselves, listen on the search-changed
signal, which emits after 300 msecs.

Bump GTK+ reqs to be the minimum version with the new signal.
Comment 4 Bastien Nocera 2013-10-22 22:13:33 UTC 
Attachment 257883 [details] pushed as d3af685 - window: Use new GtkSearchEntry feature