After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710612 - [PATCH] Allow to extend selection with mouse scrollwheel
[PATCH] Allow to extend selection with mouse scrollwheel
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkTextView
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 634127 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-10-22 08:36 UTC by Nelson Benitez
Modified: 2015-01-10 20:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GtkTextView: allow to extend text selection with mouse scrollwheel (1.42 KB, patch)
2013-10-22 08:42 UTC, Nelson Benitez
none Details | Review
Fixes bug (1.15 KB, patch)
2015-01-09 21:24 UTC, Nelson Benitez
committed Details | Review

Description Nelson Benitez 2013-10-22 08:36:21 UTC
Hi,
this patch is about fixing a bug in GtkTextView that prevents the current text selection to be extended by moving the mouse scrollwheel (with the mouse left button pressed).


Steps to reproduce:
1. Open a sufficient large text file so it can be scrolled (eg. some C file).
2. Scroll the view to somewhere in the middle of the file
3. With mouse left button do a click and keep it pressed, then move the mouse scrollwheel to start selecting text from the place you clicked.

Expected results:
Text should be selected to the mouse pointer position as we scroll the view with the scrollwheel.

Actual results:
None text is selected, and the view does not scroll past the current viewport.

Note that if we move the mouse a little while doing this (ie. we provoke a motion_notify event) then the text selection works as expected, but just using the mouse scrollwheel alone does not.
Comment 1 Nelson Benitez 2013-10-22 08:42:55 UTC
Created attachment 257821 [details] [review]
GtkTextView: allow to extend text selection with mouse scrollwheel
Comment 2 Bernhard Schuster 2014-01-22 09:04:31 UTC
Review of attachment 257821 [details] [review]:

Looks good to me, but I am not sure if I am even "allowed" to review.
Comment 3 Matthias Clasen 2014-09-27 04:39:44 UTC
*** Bug 634127 has been marked as a duplicate of this bug. ***
Comment 4 Nelson Benitez 2015-01-09 21:24:38 UTC
Created attachment 294185 [details] [review]
Fixes bug

Patch updated for latest GtkTextview code.
Comment 5 Christian Hergert 2015-01-10 01:10:18 UTC
Patch looks good to me, and works as expected.

I'd wait for someone like Matthias to ack though.
Comment 6 Nelson Benitez 2015-01-10 20:32:57 UTC
Comment on attachment 294185 [details] [review]
Fixes bug

Patch committed, closing bug.