Created attachment 257755 [details] [review]
Don't use a fake name when communicating the XDS dragged file name

    dnd: don't use a fake name when communicating the xds dragged file
    
    Use the real name, as the target application may need it (eg.
    nautilus for revealing it, or gedit to open it).

Created attachment 257756 [details] [review]
fix crash on _fr_window_ask_overwrite_dialog() function

    fr-window: fix crash on _fr_window_ask_overwrite_dialog() function
    
    Don't immediatly unref 'destination' after passing it to
    g_file_query_info_async() , instead unref it from within the callback
    for the aforementioned function when it's done with it.

Created attachment 257757 [details] [review]
Improve XDS dnd support

    fr-window: Improve XDS dnd support
    
    Improve file-roller XDS dnd support by sending the 'success'
    response only after the file(s) has already been extracted, so
    the target dnd application can operate on it (eg. gedit may
    want to open it, nautilus may want to reveal it).
    
    The XDS spec states that when sending the success ('S') response, the
    file should have already been written to disk, but assumed this would
    be done in a synchronous (and thus blocking) operation, asynchronous
    (callback based) apis were not common when the XDS spec was done so
    that's probably the reason.
    
    So as file-roller does, in a right manner, its file operations 
    asynchronously, thats probably why it didn't care to send the success 
    response at the right time.
    
    This patch workarounds the XDS spec limitation and makes file-roller to wait
    for the async operations to complete before sending the success response.
    
    It does so, without blocking the main ui thread, by creating and using a
    GMainLoop the same way as it's done by the gtk_dialog_run() call, which
    shows a dialog and waits for its response without blocking the ui.

Created attachment 257760 [details]
Screencast showing patches result of file-roller dropping files to gedit

This is a screencast showing the patches behaviour, where I drag some files from file-roller and drop it on gedit and gedit opens them, things to note:

- I dragged the same file twice just to show how gedit handles that, because every time we offer a XDS file, gedit gives as destination directory a tmp directory created with random name everytime.

- I also dragged a file which is password protected, just to show how file-roller ui does not block and we are able to enter our password while gedit waits for the xds success response which happens after we enter our password and the file is finally extracted.



Note: Take in mind if you try to drag and drop several files onto gedit only the first one will be opened, this is due to limitation of XDS spec, which does not have support for transfers of more than one file.

I forgot to add, that for gedit to work as in the screencast you need the patch in bug 430798 comment 6

Hi Nelson,

I've pushed your patches to master now.  I've then fixed drag&drop from the 
folder tree, and added some other points where to reset dnd_extract_is_running.

Thank you for your work.