GNOME Bugzilla – Bug 710542
Create a find toolbar to each tab
Last modified: 2013-12-15 14:32:37 UTC
With the patch, to each tab have a find toolbar. This mean when I type to search in one tab, and move to other tab, the find toolbar is hidden, but when I returned to the previous tab, I see again the find toolbar, with the text I typed to search.
Created attachment 257748 [details] [review] Create a find toolbar to each tab
Created attachment 257793 [details] [review] ephy-find-toolbar: Close the search bar when loading new page in the current tab
Created attachment 257795 [details] [review] ephy-find-toolbar: Close the search bar when loading new page in the current tab Don't call to ephy_find_toolbar_close() when the find bar isn't shown.
Created attachment 261451 [details] [review] The patch of ephy-find-toolbar.c This patch show the different between the original ephy-find-toolbar.c from src/ to the ephy-find-toolbar.c after the patch in this bug, in embed/ folder.
Created attachment 261452 [details] [review] The patch of ephy-find-toolbar.h This patch show the different between the original ephy-find-toolbar.c from src/ to the ephy-find-toolbar.c after the patch in this bug, in embed/ folder.
The patch looks pretty good, but you need to update it to apply to master.
Created attachment 263761 [details] [review] Create a find toolbar to each tab Updated to master.
Created attachment 263762 [details] [review] ephy-find-toolbar: Close the search bar when loading new page in the current tab Updated to master.
Created attachment 263763 [details] [review] The patch of ephy-find-toolbar.{c,h}
Review of attachment 263761 [details] [review]: Looks good. You can fix the small issues and then push. ::: embed/ephy-embed.c @@ +34,3 @@ #include "ephy-settings.h" #include "ephy-web-view.h" +#include "ephy-find-toolbar.h" This list should be sorted. ::: src/ephy-window.c @@ +1401,3 @@ if (!can_find) { + ephy_find_toolbar_request_close (ephy_embed_get_find_toolbar (window->priv->active_embed)); Can't you just use priv here?
Review of attachment 263762 [details] [review]: Same with this one, fix the small issue and push afterwards. ::: embed/ephy-find-toolbar.c @@ +430,3 @@ +ephy_find_toolbar_load_changed_cb (WebKitWebView *web_view, + WebKitLoadEvent load_event, + gpointer user_data) Use a EphyToolBar here, instead of a gpointer, like the other callbacks.
Review of attachment 263763 [details] [review]: All right. ::: embed/ephy-find-toolbar.c @@ -293,3 @@ EphyFindToolbar *toolbar) { - EphyFindToolbarPrivate *priv = toolbar->priv; How is this related? Remove it beforehand (or afterwards) if this is a left-over.
Review of attachment 263761 [details] [review]: Pushed as 610586172fd8492f826adcba0f7685bf14db747e - Create a find toolbar to each tab
Review of attachment 263762 [details] [review]: Pushed as 78b0f5ad9292edeb872bc8f418d6bc24804208fd - ephy-find-toolbar: Close the search bar when loading new page in the current tab
I pushed the patches after change by your comment. Also, I pushed a separate patch to remove the unused variable in ephy-find-toolbar.c.
*** Bug 706940 has been marked as a duplicate of this bug. ***