After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710491 - Deprecate {begin,send}_action_hash
Deprecate {begin,send}_action_hash
Status: RESOLVED FIXED
Product: GUPnP
Classification: Other
Component: gupnp
unspecified
Other All
: Normal normal
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-19 03:38 UTC by Jens Georg
Modified: 2013-11-30 09:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Deprecate {begin,send}_action_hash (3.21 KB, patch)
2013-10-19 03:38 UTC, Jens Georg 		committed Details | Review

Description Jens Georg 2013-10-19 03:38:53 UTC 
Deprecate the hash functions since they are generating incompatiblities with
most DLNA devices as they can't guarantee order of arguments
Comment 1 Jens Georg 2013-10-19 03:38:55 UTC 
Created attachment 257684 [details] [review]
Deprecate {begin,send}_action_hash

They cannot guarantee the order of arguments which breaks interaction with
DLNA-complient devices.

The use of end_action_hash is fine, though. It can be paired with all of the
begin_action_* functions.
Comment 2 Jussi Kukkonen 2013-11-26 09:06:37 UTC 
This didn't actually end up in 0.20.8, should probably be done now.
Comment 3 Jens Georg 2013-11-26 09:09:19 UTC 
Agree. 

I would also like to branch off a stable gupnp-0.20 branch and start breaking ABI and API on master to finally merge stuff like bug 654446 and the g-i issues that need API changes (https://git.gnome.org/browse/gupnp/log/?h=wip/fix-gi)
Comment 4 Jens Georg 2013-11-26 09:11:39 UTC 
And fix bug 701446 which probably needs a GDestroyNotify parameter to work correctly.
Comment 5 Jens Georg 2013-11-30 09:52:52 UTC 
Attachment 257684 [details] pushed as 423e5e8 - Deprecate {begin,send}_action_hash