After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710480 - gsm-manager: Don't abort when all clients exit
gsm-manager: Don't abort when all clients exit
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
: 725968 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-10-18 22:19 UTC by Colin Walters
Modified: 2014-03-10 15:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gsm-manager: Don't abort when all clients exit (1.16 KB, patch)
2013-10-18 22:19 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2013-10-18 22:19:08 UTC
If all of our clients exit, remove_clients_for_connection()
calls end_phase() which in turn invokes gsm_manager_quit() that
checks the logout type.

But at this point we only have _LOGOUT_NONE, so we end up aborting.
It's fine to just call _quit() in this case, and this avoids us
dumping core.

This was happening to me when session startup failed for other
reasons.
Comment 1 Colin Walters 2013-10-18 22:19:10 UTC
Created attachment 257671 [details] [review]
gsm-manager: Don't abort when all clients exit
Comment 2 Colin Walters 2013-10-23 19:36:14 UTC
Attachment 257671 [details] pushed as 6e203f4 - gsm-manager: Don't abort when all clients exit
Comment 3 Ray Strode [halfline] 2014-03-10 15:54:49 UTC
*** Bug 725968 has been marked as a duplicate of this bug. ***