After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710457 - Test data files get installed into /files if installed tests are disabled
Test data files get installed into /files if installed tests are disabled
Status: RESOLVED DUPLICATE of bug 710197
Product: glib
Classification: Platform
Component: network
2.38.x
Other Linux
: Normal minor
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-10-18 13:49 UTC by Adam Sampson
Modified: 2013-10-18 13:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to make installation conditional (674 bytes, patch)
2013-10-18 13:49 UTC, Adam Sampson 		accepted-commit_now Details | Review

Description Adam Sampson 2013-10-18 13:49:28 UTC 
Created attachment 257643 [details] [review]
Patch to make installation conditional

tls/tests/Makefile.am always installs the test data files into $(DESTDIR)$(installed_testdir)/files. However, in m4/glibtests.m4, installed_testdir isn't set unless --enable-installed-tests is given.

As a result, if you configure glib-networking without --enable-installed-tests, then the test data files get installed into $(DESTDIR)/files.

Patch attached to make installation conditional on ENABLE_INSTALLED_TESTS.
Comment 1 Colin Walters 2013-10-18 13:58:34 UTC 
Review of attachment 257643 [details] [review]:

Looks good.
Comment 2 Colin Walters 2013-10-18 13:59:23 UTC 
Oh this was already fixed.

*** This bug has been marked as a duplicate of bug 710197 ***