After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710442 - netclientclock: constify name parameter for gst_net_client_clock_new()
netclientclock: constify name parameter for gst_net_client_clock_new()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal minor
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-18 07:59 UTC by Philip Withnall
Modified: 2013-10-18 09:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
net: Constify a parameter to gst_net_client_clock_new() (1.85 KB, patch)
2013-10-18 07:59 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2013-10-18 07:59:07 UTC 
The ‘name’ parameter of gst_net_client_clock_new() should be const since (if it was used) it would never be modified.

Patch coming up.
Comment 1 Philip Withnall 2013-10-18 07:59:22 UTC 
Created attachment 257618 [details] [review]
net: Constify a parameter to gst_net_client_clock_new()

Even though this parameter is not used, it should be const to fit in with the
coding standards for other similar parameters. Client code already passes in
const strings under the expectation that they won’t be modified.
Comment 2 Tim-Philipp Müller 2013-10-18 09:00:44 UTC 
Indeed, thanks for the patch!


commit 3c8424d9ae14204d40bdd50b78d275b844fc39d8
Author: Philip Withnall <philip.withnall@collabora.co.uk>
Date:   Fri Oct 18 08:58:05 2013 +0100

    net: Constify a parameter to gst_net_client_clock_new()
    
    Even though this parameter is not used, it should be const to fit in with the
    coding standards for other similar parameters. Client code already passes in
    const strings under the expectation that they won’t be modified.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=710442