After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710389 - gdkwindow-x11: Don't set WM_TAKE_FOCUS if accept_focus is FALSE
gdkwindow-x11: Don't set WM_TAKE_FOCUS if accept_focus is FALSE
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-10-17 13:11 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-11-22 18:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdkwindow-x11: Don't set WM_TAKE_FOCUS if accept_focus is FALSE (1.53 KB, patch)
2013-10-17 13:12 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-10-17 13:11:59 UTC 
Otherwise, we'll be in the "Globally Active" mode instead of the
"No Input" mode.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-10-17 13:12:00 UTC 
Created attachment 257535 [details] [review]
gdkwindow-x11: Don't set WM_TAKE_FOCUS if accept_focus is FALSE
Comment 2 Parag AN 2013-10-20 03:13:54 UTC 
is this then valid bug?
Comment 3 Matthias Clasen 2013-10-21 17:30:23 UTC 
Review of attachment 257535 [details] [review]:

ok.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-10-21 17:44:31 UTC 
Attachment 257535 [details] pushed as 809aab2 - gdkwindow-x11: Don't set WM_TAKE_FOCUS if accept_focus is FALSE
Comment 5 Parag AN 2013-11-16 06:51:56 UTC 
When will this fix be available in Fedora 20 or 3.10.x series?
Comment 6 Parag AN 2013-11-20 13:09:32 UTC 
As I asked in #comment2 , is this really a valid bug please confirm. If this get reverted then applications which set accept_focus as FALSE works fine provided current mutter-3.10.x gets patched from bug 710296

On Fedora 20, I just updated current mutter-3.10.2 with patch from bug 710296 and downgraded gtk3 to gtk3-3.10.2 and applications like cellwriter, iok, eekboard started working again.
Comment 7 Jasper St. Pierre (not reading bugmail) 2013-11-21 05:28:09 UTC 
Both patches are correct, and either one of them will solve the bug. Does this patch break things for you?
Comment 8 Parag AN 2013-11-21 05:34:34 UTC 
My understanding is that if I update gtk3-3.10.2 to any recent update which carries this patch then all those applications remains focused and not send keyevents to active window.
Comment 9 Parag AN 2013-11-21 06:16:32 UTC 
I have tested 2 cases you said in above comment.

Fedora 20 beta (updated from updates-testing) carries gtk patch but not mutter so in its default installation OSK applications are not working as they remain focused.

If I will add patch to current fedora mutter-3.10.2-2.fc20 package and downgrade gtk3-3.10.4-1.fc20 to gtk3-3.10.2-2.fc20 then OSK applications will start working again.
Comment 10 Jasper St. Pierre (not reading bugmail) 2013-11-22 18:05:33 UTC 
This was a mutter bug. Can of worms style bug, but patches are in https://bugzilla.gnome.org/show_bug.cgi?id=715030