After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710383 - Only build upower for upower <= 0.9.0
Only build upower for upower <= 0.9.0
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-17 12:34 UTC by Colin Walters
Modified: 2014-01-03 06:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
logout-dialog: Just use GsmSystem rather than UPower (2.24 KB, patch)
2013-10-17 13:09 UTC, Colin Walters 		accepted-commit_now Details | Review
Only support UPower 0.9 (3.64 KB, patch)
2013-10-17 13:09 UTC, Colin Walters 		reviewed Details | Review
Only support UPower 0.9 (3.54 KB, patch)
2013-10-17 13:55 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2013-10-17 12:34:11 UTC 
We can't support 1.0 with this code as it removed the APIs which overlapped with logind.  People should move towards implementing the logind APIs on non-systemd systems.
Comment 1 Colin Walters 2013-10-17 13:09:10 UTC 
Created attachment 257533 [details] [review]
logout-dialog: Just use GsmSystem rather than UPower

GsmSystem already has this stuff abstracted.
Comment 2 Colin Walters 2013-10-17 13:09:12 UTC 
Created attachment 257534 [details] [review]
Only support UPower 0.9

Newer UPower drops support for APIs that duplicate systemd/logind, so
if we detect it, then require consumers to use the systemd backend.
Comment 3 Ray Strode [halfline] 2013-10-17 13:32:40 UTC 
Review of attachment 257534 [details] [review]:

::: configure.ac
@@ +72,3 @@
+dnl We can only support old upower
+dnl https://bugzilla.gnome.org/show_bug.cgi?id=710383
+PKG_CHECK_MODULES(UPOWER, upower-glib >= $UPOWER_REQUIRED)

So we don't actually use UPOWER directly on recent systems, right? maybe we shouldn't require it for them?
Comment 4 Colin Walters 2013-10-17 13:55:31 UTC 
Created attachment 257540 [details] [review]
Only support UPower 0.9

Simplify version check, and avoid linking to upower if we're not using it.
Comment 5 Ray Strode [halfline] 2013-10-17 14:19:53 UTC 
Review of attachment 257533 [details] [review]:

++
Comment 6 Ray Strode [halfline] 2013-10-17 14:20:07 UTC 
Review of attachment 257540 [details] [review]:

++
Comment 7 Colin Walters 2013-10-17 14:29:08 UTC 
Attachment 257540 [details] pushed as 3b518ca - Only support UPower 0.9
Comment 8 Allison Karlitskaya (desrt) 2014-01-03 06:59:42 UTC 
See bug 721380.